Incorrect environment variable name being used in documentation and in the template generated by the choco new command #3685
Description
Checklist
- I confirm there are no unresolved issues reported on the Chocolatey Status page.
- I have verified this is the correct repository for opening this issue.
- I have verified no other issues exist related to my problem.
- I have verified this is not an issue for a specific package.
- I have verified this issue is not security related.
- I confirm I am using official, and not unofficial, or modified, Chocolatey products.
What You Are Seeing?
In the documentation for Chocolatey CLI, as well as the default template for the choco new command, there is mention of an environment variable called ChocolateyPackageExitCode, and that this is set by the Set-PowerShellExitCode function. However, that function actually sets an environment variable called ChocolateyExitCode. One of these things is not correct!
What is Expected?
The documentation should match what the source code is using.
How Did You Get This To Happen?
Read the source code and compared it to the documentation, and noticed the difference. This came up as part of reviewing @AdmiringWorm PR here:
System Details
- Operating System: Windows 11
- Windows PowerShell version: 7.5.1
- Chocolatey CLI Version: 2.4.3
- Chocolatey Licensed Extension version: 6.3.1
- Chocolatey License type: Business
- Terminal/Emulator: PowerShell
Installed Packages
N/A
Output Log
N/A
Additional Context
This is related to the changes that were being done in this PR: