Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcportal 0.50 is incompatible with espaloma #185

Open
pavankum opened this issue Sep 18, 2023 · 10 comments
Open

qcportal 0.50 is incompatible with espaloma #185

pavankum opened this issue Sep 18, 2023 · 10 comments
Labels
installation 🛠️ I can't install espaloma

Comments

@pavankum
Copy link

Hi,

The new version of qcportal 0.50 is incompatible with the current espaloma package, may have to pin down to 0.15.8 or other in that line. It throws this error:

Traceback (most recent call last):
  File "/espaloma/../../utils/espaloma_minimization.py", line 1, in <module>
    import espaloma as esp
  File "miniconda3/envs/espaloma/lib/python3.10/site-packages/espaloma/__init__.py", line 6, in <module>
    from . import metrics, units, data, app, graphs, mm, nn
  File "miniconda3/envs/espaloma/lib/python3.10/site-packages/espaloma/data/__init__.py", line 2, in <module>
    from . import dataset, md, normalize, utils, qcarchive_utils, md17_utils
  File "miniconda3/envs/espaloma/lib/python3.10/site-packages/espaloma/data/qcarchive_utils.py", line 105, in <module>
    def fetch_td_record(record: ptl.models.torsiondrive.TorsionDriveRecord):
AttributeError: module 'qcportal' has no attribute 'models'
@jchodera
Copy link
Member

qcportal 0.50 was released 6 days ago and has API-breaking changes.

@mikemhenry : Can you help us update the espaloma conda package to pin to 0.15.8?

We'll have to update to the new qcportal 0.50 API for releases beyond espaloma 0.3 since the paper is imminent.

@jchodera jchodera added the installation 🛠️ I can't install espaloma label Sep 18, 2023
@ijpulidos
Copy link
Contributor

I tried to look for a CHANGELOG (or similar) but I couldn't easily find one, do we know if there's documentation on what was changed? Just such that it's easier to know what to adapt on our end, if possible. I know the qcportal package is now being developed inside the qcfractal repo.

@pavankum
Copy link
Author

@ijpulidos here is the new documentation, there are a ton of changes and new ways to access data, might be better to join the QCA call on Tuesdays for feedback from Ben and David.

@jchodera
Copy link
Member

@chrisiacovella has been joining those calls---perhaps he would be in a good position to help fix this up?

@mikemhenry
Copy link
Contributor

I can submit a repodata patch to add the pin since I think that will be faster than updating the API and then cutting a new release, but I do agree it would be better to update espaloma to work with the new qcportal.

@mikemhenry
Copy link
Contributor

Looks like openff had the same issue conda-forge/conda-forge-repodata-patches-feedstock#550

@chrisiacovella
Copy link
Member

Pinning to the old version is probably the best immediate fix (as syntax has completely changed, for the better, in the newest version). I'm currently working on putting essentially the same routines into model forge, so I can create a PR updating the syntax, including the much more efficient ways to fetch the records that have been introduced in the new code.

@mikemhenry
Copy link
Contributor

Patch here conda-forge/conda-forge-repodata-patches-feedstock#555

@mikemhenry
Copy link
Contributor

Also in the meantime, adding "qcportal<0.50.0a0" when installing espaloma will work.

@mikemhenry
Copy link
Contributor

Also update the recipe as well conda-forge/espaloma-feedstock#9 but that fix will not be retroactive like the repodata patch will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation 🛠️ I can't install espaloma
Projects
None yet
Development

No branches or pull requests

5 participants