Skip to content

Fix feptasks.minimize()'s minimisation_steps argument #1086

@zhang-ivy

Description

@zhang-ivy

minimisation_steps, an argument to feptasks.minimize() , currently matches the openmm LocalEnergyMinimizer.minimize() argument maxIterations in that when its equal to 0, it will run as many steps of minimization as needed, not zero steps.

minimisation_steps should work like this instead:

  • None should be interpreted to run until tolerance is reached
  • 0 should be interpreted to run 0 steps

See thread: #1065 (comment)

related: #1083

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions