Skip to content

Commit 7c6e078

Browse files
Replace findup by @choojs/findup (#465)
@choojs/findup is a fork of findup that removes the `colors` dependency. `colors` adds lots of properties to the String prototype, which was causing big slowdowns in bankai. About 300ms was spent calling `colors` getters that were never expected to be there (mostly by the CSS parser).
1 parent cae451d commit 7c6e078

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

lib/graph-service-worker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var debug = require('debug')('bankai.graph-service-worker')
2+
var findup = require('@choojs/findup')
23
var assert = require('assert')
3-
var findup = require('findup')
44
var path = require('path')
55

66
var browserify = require('browserify')

lib/is-electron-project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var explain = require('explain-error')
2-
var findup = require('findup')
2+
var findup = require('@choojs/findup')
33
var path = require('path')
44
var fs = require('fs')
55

lib/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var recursiveWatch = require('recursive-watch')
2-
var findup = require('findup')
2+
var findup = require('@choojs/findup')
33
var Debug = require('debug')
44
var path = require('path')
55

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
},
1717
"keywords": [],
1818
"dependencies": {
19+
"@choojs/findup": "^0.2.0",
1920
"ansi-diff": "^1.0.10",
2021
"ansi-escape-sequences": "^4.0.0",
2122
"async-collection": "^1.0.1",
@@ -38,7 +39,6 @@
3839
"exorcist": "^1.0.0",
3940
"explain-error": "^1.0.4",
4041
"fast-json-parse": "^1.0.3",
41-
"findup": "^0.1.5",
4242
"flush-write-stream": "^1.0.2",
4343
"fs-compare": "^0.0.4",
4444
"get-port": "^3.2.0",

0 commit comments

Comments
 (0)