Skip to content

Commit ce74f75

Browse files
authored
support content and public dirs in http (#463)
1 parent 0f7ce4c commit ce74f75

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

http.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ function start (entry, opts) {
118118
})
119119
})
120120

121-
router.route(/^\/assets\/([^?]*)(\?.*)?$/, function (req, res, params) {
122-
var prefix = 'assets' // TODO: also accept 'content'
123-
var name = prefix + '/' + params[1]
121+
router.route(/^\/(assets|content|public)\/([^?]*)(\?.*)?$/, function (req, res, params) {
122+
var prefix = params[1] // asset dir
123+
var name = prefix + '/' + params[2]
124124
compiler.assets(name, function (err, filename) {
125125
if (err) {
126126
res.statusCode = 404

test/http.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,20 @@ function setup () {
3030

3131
var dirname = 'manifest-pipeline-' + (Math.random() * 1e4).toFixed()
3232
tmpDirname = path.join(os.tmpdir(), dirname)
33+
var contentDirname = path.join(tmpDirname, 'content')
3334
var assetDirname = path.join(tmpDirname, 'assets')
3435
var assetSubdirname = path.join(assetDirname, 'images')
3536

3637
tmpScriptname = path.join(tmpDirname, 'index.js')
37-
var tmpFilename = path.join(assetDirname, 'file.txt')
38+
var tmpFilename = path.join(contentDirname, 'file.txt')
3839
var tmpAssetJsFilename = path.join(assetDirname, 'file.js')
3940
var tmpAssetCssFilename = path.join(assetDirname, 'file.css')
4041
var tmpJsonFilename = path.join(assetDirname, 'file.json')
4142
var tmpJpgFilename = path.join(assetDirname, 'file.jpg')
4243
var tmpJpgSubFilename = path.join(assetSubdirname, 'file.jpg')
4344

4445
fs.mkdirSync(tmpDirname)
46+
fs.mkdirSync(contentDirname)
4547
fs.mkdirSync(assetDirname)
4648
fs.mkdirSync(assetSubdirname)
4749
fs.writeFileSync(tmpScriptname, script)
@@ -74,8 +76,8 @@ tape('should route urls appropriately', function (assert) {
7476
'/bundle.js?cache=busted',
7577
'/bundle.css',
7678
'/bundle.css?cache=busted',
77-
'/assets/file.txt',
78-
'/assets/file.txt?cache=busted',
79+
'/content/file.txt',
80+
'/content/file.txt?cache=busted',
7981
'/assets/file.json',
8082
'/assets/file.css',
8183
'/assets/file.css?cache=busted',

0 commit comments

Comments
 (0)