Add tests for the MASI distance

Author: choroba

t/01-deltas.t

@@ -34,26 +34,30 @@ is $sk->delta_jaccard('a,b,c', 'b,c,d,e'), 3/5, 'abc bcde';
 
 is $sk->delta_masi('1,2', '1,2,3,4'), 2/3, 'masi';
 
+# Passonneau 2006
+# Note that the results are different than stated in the article, I fixed
+# errors found in the article, results confirmed by Passonneau via e-mail.
 my @figures = (
-    [['x,y', 'x,y,z'], ['x,y', 'x,y,z'], ['x', 'x,y,z']],
+    [['x,y', 'x,y,z'], ['x,y', 'x,y,z'], ['z', 'x,y,z']],
     [['x,y', 'x'], ['x,y', 'y,z'], ['z', 'y,z']]
 );
 
 my %means = (jaccard => [4 / 9, 5 / 9],
-             masi    => [10 / 27, 6 / 27]);
+             masi    => [2 / 9, 0]);
 for my $figure_index (0 .. $#figures) {
     my $figure = $figures[$figure_index];
+    my $figure_number = 2 + $figure_index;
     my @jaccard_deltas = map $sk->delta_jaccard(@$_), @$figure;
     my $j_mean = sum(@jaccard_deltas) / @jaccard_deltas;
-    is $j_mean, shift @{ $means{jaccard} }, "fig$figure_index jaccard mean";
+    is $j_mean, shift @{ $means{jaccard} }, "fig$figure_number jaccard mean";
 
-    if (1 == $figure_index) {
-        $figure->[1] = ['x', 'z'];
+    if (0 == $figure_index) {
+        $figure = [['y', 'y,z'], ['x', 'x,z'], ['','x,y']];
     } else {
-        #$figure = [['y', 'y,z'], ['x', 'x,z'], ['x','x,y']];
+        $figure = [['y', ''], ['x', 'z'], ['', 'y']];
     }
 
     my @masi_deltas = map $sk->delta_masi(@$_), @$figure;
     my $m_mean = 1 - sum(@masi_deltas) / @masi_deltas;
-    is $m_mean, shift @{ $means{masi} }, "fig$figure_index masi mean";
+    is $m_mean, shift @{ $means{masi} }, "fig$figure_number masi mean";
 }