Change Textobj: Consider extending {notifyNotFound=false} to indentation object's warning "Current line is not indented"

[tuurep]

Change requested

I'd prefer to have all warnings turned off when there's nothing to be done, so would feel consistent if for example dii on an unindented line wouldn't give a warning message either when notifyNotFound=false

Looks like there's also a warning "No indented line found." (code) associated with indentation textobj, but I haven't found in what situation that emits. But most likely my request concerns that too.

Relevant PR where notifyNotFound was added: #85

Sample Text

require("various-textobjs").setup({notifyNotFound = false})

Unindented line hello foo bar
^

Press dii

Gives warning "Current line is not indented."

But could it be quiet?

Checklist

• The textobj would be useful to more users than just me. (You can use the API to create custom textobj.)
• This is a feature request to change an existing textobject, not a bug report. (Use the bug report form for those.)

[tuurep]

It could be opinionated though because this isn't the same kind of "not found within n lines" message as the one disabled by notifyNotFound=false.

Alternative idea: some kinda quiet option, as a sort of second level of quietness.

[chrisgrieser]

Ah yes, those two were simply overlooked. Can you make a PR adding notifyNotFound as conditional to those two notifications?

(I'm not at home for a bit but I have Github mobile access, where accepting PRs is ready though)

[tuurep]

Thanks, yeah I can make one and good to know my request made perfect sense :)

[tuurep]

Although are there more cases related to this? Examples:

nvim-various-textobjs/lua/various-textobjs/charwise-textobjs.lua

Line 265 in b8f7e97

u.notify("No diagnostic found.", "warn")

nvim-various-textobjs/lua/various-textobjs/charwise-textobjs.lua

Line 417 in b8f7e97

u.notify("No node found.", "warn")

nvim-various-textobjs/lua/various-textobjs/charwise-textobjs.lua

Line 429 in b8f7e97

u.notify("Not on a triple quoted string.", "warn")

Edit:

Yeah the reason it is the way it is is because the only place where notifyNotFound is checked against is here:

nvim-various-textobjs/lua/various-textobjs/utils.lua

Lines 28 to 35 in b8f7e97

	---notification when no textobj could be found
	---@param lookForwL integer number of lines the plugin tried to look forward
	function M.notFoundMsg(lookForwL)
	if not require("various-textobjs.config").config.notifyNotFound then return end
	local msg = "Textobject not found within the next " .. tostring(lookForwL) .. " lines."
	if lookForwL == 1 then msg = msg:gsub("s%.$", ".") end -- remove plural s
	M.notify(msg, "warn")
	end

So I'm wondering whether we want to wrap other warnings in a similar util function and check it there too, or if there's a need to have more granularity (a second quietflag)?

[chrisgrieser]

fixed all cases

[tuurep]

Astonishing. Thank you very much 😄