TF-1487 Apply linter rule

Author: dab246

analysis_options.yaml

@@ -10,20 +10,7 @@
 include: package:flutter_lints/flutter.yaml
 
 linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
   rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+    constant_identifier_names: false
+    non_constant_identifier_names: false
+    unnecessary_string_escapes: false

contact/analysis_options.yaml

@@ -1,4 +1,16 @@
+# This file configures the analyzer, which statically analyzes Dart code to
+# check for errors, warnings, and lints.
+#
+# The issues identified by the analyzer are surfaced in the UI of Dart-enabled
+# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
+# invoked from the command line by running `flutter analyze`.
+
+# The following line activates a set of recommended lints for Flutter apps,
+# packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
 
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+linter:
+  rules:
+    constant_identifier_names: false
+    non_constant_identifier_names: false
+    unnecessary_string_escapes: false

core/analysis_options.yaml

@@ -10,20 +10,7 @@
 include: package:flutter_lints/flutter.yaml
 
 linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
   rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+    constant_identifier_names: false
+    non_constant_identifier_names: false
+    unnecessary_string_escapes: false

core/lib/core.dart

@@ -73,7 +73,6 @@ export 'presentation/views/bottom_popup/confirmation_dialog_action_sheet_builder
 export 'presentation/views/modal_sheets/edit_text_modal_sheet_builder.dart';
 export 'presentation/views/search/search_bar_view.dart';
 export 'presentation/views/popup_menu/popup_menu_item_widget.dart';
-export 'presentation/views/tab_bar/custom_tab_indicator.dart';
 export 'presentation/views/quick_search/quick_search_input_form.dart';
 export 'presentation/views/toast/toast_position.dart';
 export 'presentation/views/toast/tmail_toast.dart';
@@ -95,8 +94,6 @@ export 'data/network/dio_client.dart';
 export 'data/network/download/download_client.dart';
 export 'data/network/download/download_manager.dart';
 export 'data/network/download/downloaded_response.dart';
-export 'data/network/download/download_client.dart';
-export 'domain/exceptions/web_session_exception.dart';
 
 // State
 export 'presentation/state/success.dart';

core/lib/presentation/extensions/color_extension.dart

@@ -1,5 +1,3 @@
-import 'dart:ui' show Color;
-
 import 'package:flutter/material.dart';
 
 extension AppColor on Color {
@@ -197,3 +195,12 @@ extension AppColor on Color {
       .toUpperCase()}';
 }
 
+extension ColorNullableExtension on Color? {
+  ColorFilter? asFilter({BlendMode? blendMode}) {
+    if (this == null) {
+      return null;
+    } else {
+      return ColorFilter.mode(this!, blendMode ?? BlendMode.srcIn);
+    }
+  }
+}

core/lib/presentation/extensions/url_extension.dart

@@ -11,7 +11,7 @@ extension URLExtension on String {
       } else if (startsWith(prefixUrlHttp)) {
         return kReleaseMode ? replaceAll(prefixUrlHttp, prefixUrlHttps) : this;
       } else {
-        return '$prefixUrlHttps${this}';
+        return '$prefixUrlHttps$this';
       }
     }
     return '';

core/lib/presentation/state/app_state.dart

@@ -1,7 +1,8 @@
-import 'package:core/core.dart';
+import 'package:core/presentation/state/failure.dart';
+import 'package:core/presentation/state/success.dart';
 import 'package:dartz/dartz.dart';
-import 'package:meta/meta.dart';
 import 'package:equatable/equatable.dart';
+import 'package:flutter/material.dart';
 
 @immutable
 abstract class AppState with EquatableMixin {

core/lib/presentation/utils/app_toast.dart

@@ -171,7 +171,7 @@ class AppToast {
                   width: 24,
                   height: 24,
                   fit: BoxFit.fill,
-                  color: iconColor),
+                  colorFilter: iconColor.asFilter()),
             if (icon != null)
               const SizedBox(width: 10.0),
             Expanded(child: Text(

core/lib/presentation/utils/theme_utils.dart

@@ -21,8 +21,8 @@ class ThemeUtils {
 
   static TextTheme get _textTheme {
     return const TextTheme(
-      bodyText1: TextStyle(color: AppColor.baseTextColor),
-      bodyText2: TextStyle(color: AppColor.baseTextColor),
+      bodyMedium: TextStyle(color: AppColor.baseTextColor),
+      bodySmall: TextStyle(color: AppColor.baseTextColor),
     );
   }
 

core/lib/presentation/views/background/background_widget_builder.dart

@@ -43,6 +43,7 @@ class BackgroundWidgetBuilder extends StatelessWidget {
     return Container(
       color: Colors.transparent,
       padding: const EdgeInsets.symmetric(horizontal: 12),
+      height: MediaQuery.of(context).size.height,
       child: Column(
         mainAxisAlignment: responsiveUtils.isLandscapeMobile(context)
           ? MainAxisAlignment.start
@@ -83,7 +84,6 @@ class BackgroundWidgetBuilder extends StatelessWidget {
             )
         ],
       ),
-      height: MediaQuery.of(context).size.height,
     );
   }
 }