734 fix swagger tags #735
Merged
734 fix swagger tags #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing brackets to vulnerbilities tags Change cpes endpoint tags to CPEs Change cves endpoint tags to CVEs Change domain endpoint tags to Domains Change vulnerabilities endpoint tags to Vulnerabilities Change api-keys endpoint tags to API Keys Change auth endpoint tags to Auth Change saved-searches endpoint tags to Saved Searches Change notifications endpoint tags to Notifications Change stats endpoint tags to Stats
aloftus23
approved these changes
Dec 9, 2024
|
@aloftus23 I re-requested your review. I reordered the endpoints so the tags are alphabetized on the swagger docs page. |
Add missing brackets to vulnerbilities tags Change cpes endpoint tags to CPEs Change cves endpoint tags to CVEs Change domain endpoint tags to Domains Change vulnerabilities endpoint tags to Vulnerabilities Change api-keys endpoint tags to API Keys Change auth endpoint tags to Auth Change saved-searches endpoint tags to Saved Searches Change notifications endpoint tags to Notifications Change stats endpoint tags to Stats
Matthew-Grayson
requested review from
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
cduhn17
reviewed
Dec 26, 2024
|
|
||
| Returns: | ||
| JSONResponse: The result of the update. |
There was a problem hiding this comment.
What are we doing for exceptions, since we are removing the exceptions?
There was a problem hiding this comment.
I see what happened. The exception is still there on line 1181. Reordering the endpoints created some weirdness with the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Update endpoint tags in views.py for consistency.
Alphabetize endpoints by tag.
💭 Motivation and context
Organizes endpoints in swagger documentation into neat categories and fixes duplication of listed endpoints.
Closes issue #734
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist