Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage secrets #9

Open
king-alexander opened this issue Jun 29, 2022 · 1 comment
Open

Manage secrets #9

king-alexander opened this issue Jun 29, 2022 · 1 comment
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use need info This issue or pull request requires further information

Comments

@king-alexander
Copy link
Collaborator

💡 Summary

Move all sensitive data -- in particular, CELERY_BROKER_URL -- into the secrets raft.

Motivation and context

We shouldn’t store any sensitive data in source control. Additionally, we want a layer of abstraction between these containers and the set of credentials. This makes for better secret management.

@king-alexander king-alexander added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 29, 2022
@king-alexander king-alexander transferred this issue from cisagov/admiral Mar 23, 2023
@king-alexander king-alexander self-assigned this Mar 23, 2023
@king-alexander king-alexander moved this from READY to WIP in 👨‍✈️ Admiral Jun 13, 2023
@king-alexander
Copy link
Collaborator Author

king-alexander commented Jun 13, 2023

I haven't found a good reference for how to make the URL a secret. The simple, but non-elegant, solution would be to define the URL in a secret text file, but that would lead to unnecessary duplication. I need a way to configure the workers and flower from the same file.

@king-alexander king-alexander moved this from WIP to READY in 👨‍✈️ Admiral Jun 16, 2023
@king-alexander king-alexander moved this from READY to BACKLOG in 👨‍✈️ Admiral Jun 23, 2023
@king-alexander king-alexander moved this from BACKLOG to READY in 👨‍✈️ Admiral Jun 23, 2023
@king-alexander king-alexander added the need info This issue or pull request requires further information label Jun 23, 2023
@king-alexander king-alexander moved this from READY to BACKLOG in 👨‍✈️ Admiral Jun 23, 2023
@king-alexander king-alexander moved this from BACKLOG to READY in 👨‍✈️ Admiral Jul 28, 2023
@king-alexander king-alexander moved this from READY to WIP in 👨‍✈️ Admiral Jul 31, 2023
@king-alexander king-alexander moved this from WIP to BACKLOG in 👨‍✈️ Admiral Aug 2, 2023
@king-alexander king-alexander moved this from BACKLOG to READY in 👨‍✈️ Admiral Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use need info This issue or pull request requires further information
Projects
None yet
Development

No branches or pull requests

1 participant