Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section about "things to keep in mind when reviewing a PR". #49

Open
felddy opened this issue Apr 26, 2021 · 1 comment
Open

Add a section about "things to keep in mind when reviewing a PR". #49

felddy opened this issue Apr 26, 2021 · 1 comment

Comments

@felddy
Copy link
Member

felddy commented Apr 26, 2021

That is a good point, although we devs tend to have a hard time knowing or remembering what normies know and don't know. It's definitely something to keep in mind when reviewing other devs' pull requests.

This triggered a thought: Should we have a document in our dev guide that talks about reviewing PRs and has a list of thangs like this to keep in mind? I think such a document could be useful, but could also turn into a list that is too long and random to be of any use. Does 18F or TTS have a document we can borrow/steal?

Originally posted by @jsf9k in cisagov/skeleton-docker#51 (comment)

@jsf9k
Copy link
Member

jsf9k commented Apr 26, 2021

Great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants