Current Behavior

If you have a domain in the status of deleted, then have a domain application with the domain name as the same name, you cannot approve that application because it looks like that domain already exists.

Expected Behavior

An analyst should be able to approve a domain application that just happens to have the same name as a different domain that has already been deleted

Steps to Reproduce

1.create a domain in the status of deleted
2. make a domain application have that domain name
3. approve the domain application
4. see error

AC

• If a domain is deleted then a domain request of the same name can be approved and another domain of that same name created.
• the above can be repeated such that there are multiple deleted domains with the same name, yet only one domain request of that name exists in a non-deleted state at any given moment.
• go through the code and audit any instance where we are getting a domain/domain info based on the name, assuming only one value will be returned. If found, update the code where needed to account for 2+ domains existing with the same name (only one in a non-deleted state)
  • if you don't find any changes are needed just mention that on your PR for a reviewer to double check

Environment

No response

Additional Context

The following are notes for implementation based on previous instructions, use your best judgment as these aren't AC, you may find you want to make different changes when evaluating this ticket:

• change domain.py model such that the name field has unique set to false
• change the domain request approve function so that the when it checks if a domain already exists it ignores a domain in the deleted
• change the Domain so that it uses the uniqueConstraint setting see below.

 class Meta:
        constraints = [
            models.UniqueConstraint(
                fields=["name"], #field to check
                condition=~models.Q(state=State.DELETED),  # state!= deleted
                name="unique_name_except_deleted"
            )
        ]

You need to go through the whole codebase to find any time we are getting the domain (or domain info) object by domain name because we want to avoid an error occurring where our code expected only one domain returned but 2 are returned. There may not be any case of this, as we should be using pks, but definitely take the time to double check this.

Issue Links

Related to: #804