Skip to content

Commit 205f299

Browse files
author
mcdonnnj
committed
Merge https://github.com/cisagov/skeleton-docker into lineage/skeleton
2 parents b93057b + 0a2e987 commit 205f299

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Diff for: requirements-dev.txt

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
--requirement requirements-test.txt
22
ipython
33
pipenv
4-
# The bump-version script requires at least version 3 of semver.
5-
semver>=3

Diff for: requirements-test.txt

+2
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
pre-commit
33
pytest
44
python-on-whales
5+
# The bump-version script requires at least version 3 of semver.
6+
semver>=3

Diff for: tests/container_test.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
# Third-Party Libraries
1414
import pytest
15+
from semver import parse_version_info
1516

1617
ENV_VAR = "ECHO_MESSAGE"
1718
ENV_VAR_VAL = "Hello World from docker compose!"
@@ -132,9 +133,9 @@ def test_log_version(dockerc, project_version, version_container):
132133
"""Verify the container outputs the correct version to the logs."""
133134
# make sure container exited if running test isolated
134135
dockerc.wait(version_container.id)
135-
log_output = version_container.logs().strip()
136-
assert (
137-
log_output == project_version
136+
log_version = parse_version_info(version_container.logs().strip())
137+
assert log_version == parse_version_info(
138+
project_version
138139
), f"Container version output to log does not match project version file {VERSION_FILE}"
139140

140141

0 commit comments

Comments
 (0)