Skip to content

Commit 028f652

Browse files
jsf9kmcdonnnj
andcommitted
Do not disable GitHub permissions monitoring by default
But do leave a commented-out line that can be uncommented to do so. The idea is that we should only comment out this functionality where we really must. Co-authored-by: Nick M <[email protected]>
1 parent ca757aa commit 028f652

File tree

4 files changed

+32
-24
lines changed

4 files changed

+32
-24
lines changed

.github/workflows/build.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ jobs:
4141
with:
4242
check_github_status: "true"
4343
# This functionality is poorly implemented and has been
44-
# causing a lot of problems due to the MITM implementation
45-
# hogging or leaking memory, so we disable it for now.
46-
monitor_permissions: "false"
44+
# causing problems due to the MITM implementation hogging or
45+
# leaking memory. If this happens to you just uncomment
46+
# this line.
47+
# monitor_permissions: "false"
4748
output_workflow_context: "true"
4849
# Use a variable to specify the permissions monitoring
4950
# configuration. By default this will yield the
@@ -71,9 +72,10 @@ jobs:
7172
uses: cisagov/action-job-preamble@v1
7273
with:
7374
# This functionality is poorly implemented and has been
74-
# causing a lot of problems due to the MITM implementation
75-
# hogging or leaking memory, so we disable it for now.
76-
monitor_permissions: "false"
75+
# causing problems due to the MITM implementation hogging or
76+
# leaking memory. If this happens to you just uncomment
77+
# this line.
78+
# monitor_permissions: "false"
7779
# Use a variable to specify the permissions monitoring
7880
# configuration. By default this will yield the
7981
# configuration stored in the cisagov organization-level

.github/workflows/codeql-analysis.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ jobs:
3838
with:
3939
check_github_status: "true"
4040
# This functionality is poorly implemented and has been
41-
# causing a lot of problems due to the MITM implementation
42-
# hogging or leaking memory, so we disable it for now.
43-
monitor_permissions: "false"
41+
# causing problems due to the MITM implementation hogging or
42+
# leaking memory. If this happens to you just uncomment
43+
# this line.
44+
# monitor_permissions: "false"
4445
output_workflow_context: "true"
4546
# Use a variable to specify the permissions monitoring
4647
# configuration. By default this will yield the
@@ -84,9 +85,10 @@ jobs:
8485
uses: cisagov/action-job-preamble@v1
8586
with:
8687
# This functionality is poorly implemented and has been
87-
# causing a lot of problems due to the MITM implementation
88-
# hogging or leaking memory, so we disable it for now.
89-
monitor_permissions: "false"
88+
# causing problems due to the MITM implementation hogging or
89+
# leaking memory. If this happens to you just uncomment
90+
# this line.
91+
# monitor_permissions: "false"
9092
# Use a variable to specify the permissions monitoring
9193
# configuration. By default this will yield the
9294
# configuration stored in the cisagov organization-level

.github/workflows/dependency-review.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@ jobs:
2929
with:
3030
check_github_status: "true"
3131
# This functionality is poorly implemented and has been
32-
# causing a lot of problems due to the MITM implementation
33-
# hogging or leaking memory, so we disable it for now.
34-
monitor_permissions: "false"
32+
# causing problems due to the MITM implementation hogging or
33+
# leaking memory. If this happens to you just uncomment
34+
# this line.
35+
# monitor_permissions: "false"
3536
output_workflow_context: "true"
3637
# Use a variable to specify the permissions monitoring
3738
# configuration. By default this will yield the
@@ -60,9 +61,10 @@ jobs:
6061
uses: cisagov/action-job-preamble@v1
6162
with:
6263
# This functionality is poorly implemented and has been
63-
# causing a lot of problems due to the MITM implementation
64-
# hogging or leaking memory, so we disable it for now.
65-
monitor_permissions: "false"
64+
# causing problems due to the MITM implementation hogging or
65+
# leaking memory. If this happens to you just uncomment
66+
# this line.
67+
# monitor_permissions: "false"
6668
# Use a variable to specify the permissions monitoring
6769
# configuration. By default this will yield the
6870
# configuration stored in the cisagov organization-level

.github/workflows/sync-labels.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@ jobs:
2525
with:
2626
check_github_status: "true"
2727
# This functionality is poorly implemented and has been
28-
# causing a lot of problems due to the MITM implementation
29-
# hogging or leaking memory, so we disable it for now.
30-
monitor_permissions: "false"
28+
# causing problems due to the MITM implementation hogging or
29+
# leaking memory. If this happens to you just uncomment
30+
# this line.
31+
# monitor_permissions: "false"
3132
output_workflow_context: "true"
3233
# Use a variable to specify the permissions monitoring
3334
# configuration. By default this will yield the
@@ -57,9 +58,10 @@ jobs:
5758
uses: cisagov/action-job-preamble@v1
5859
with:
5960
# This functionality is poorly implemented and has been
60-
# causing a lot of problems due to the MITM implementation
61-
# hogging or leaking memory, so we disable it for now.
62-
monitor_permissions: "false"
61+
# causing problems due to the MITM implementation hogging or
62+
# leaking memory. If this happens to you just uncomment
63+
# this line.
64+
# monitor_permissions: "false"
6365
# Use a variable to specify the permissions monitoring
6466
# configuration. By default this will yield the
6567
# configuration stored in the cisagov organization-level

0 commit comments

Comments
 (0)