Merge pull request #63 from RichLogan/patch-bitshift

bifurcation · web-flow · commit f047335e2d3e · 2025-05-02T11:07:35.000-04:00
Fix max ID calculation
diff --git a/src/sframe.cpp b/src/sframe.cpp
@@ -302,8 +302,8 @@ MLSContext::EpochKeys::EpochKeys(MLSContext::EpochID full_epoch_in,
   }
 
   context_bits = key_id_bits - sender_bits - epoch_bits;
-  max_sender_id = (one << (sender_bits + 1)) - 1;
-  max_context_id = (one << (context_bits + 1)) - 1;
+  max_sender_id = (one << sender_bits) - 1;
+  max_context_id = (one << context_bits) - 1;
 }
 
 owned_bytes<MLSContext::EpochKeys::max_secret_size>

Original file line number	Diff line number	Diff line change
`@@ -302,8 +302,8 @@ MLSContext::EpochKeys::EpochKeys(MLSContext::EpochID full_epoch_in,`
`302`	`302`	`}`
`303`	`303`
`304`	`304`	`context_bits = key_id_bits - sender_bits - epoch_bits;`
`305`		`- max_sender_id = (one << (sender_bits + 1)) - 1;`
`306`		`- max_context_id = (one << (context_bits + 1)) - 1;`
	`305`	`+ max_sender_id = (one << sender_bits) - 1;`
	`306`	`+ max_context_id = (one << context_bits) - 1;`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`owned_bytes<MLSContext::EpochKeys::max_secret_size>`