Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to GUCs that are no longer present #1071

Open
hanefi opened this issue Jan 23, 2023 · 0 comments
Open

Remove references to GUCs that are no longer present #1071

hanefi opened this issue Jan 23, 2023 · 0 comments
Assignees

Comments

@hanefi
Copy link
Member

hanefi commented Jan 23, 2023

Why are we implementing it? (sales eng)

We removed some GUCs in the past, and we still keep references to them in the docs. Recently it caused some confusion among team members.

  • citus.binary_worker_copy_format - not present on >= 11.1.0
  • citus.multi_shard_commit_protocol - not present on >= 11.0.0_beta
  • citus.shard_max_size - not present on >= 11.0.0_beta

What are the typical use cases?

Communication goals (e.g. detailed howto vs orientation)

Good locations for content in docs structure

Check all occurences of these GUCS and remove all references. Some of the changes may require understanding how the behavior changed after we removed these GUCs.

How does this work? (devs)

Example sql

Corner cases, gotchas

It is not only the latest version of Citus that is affected. We should backport some of the commits to earlier versions as well.

Are there relevant blog posts or outside documentation about the concept/feature?

Link to relevant commits and regression tests if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants