Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address compiler warnings on some packaging platforms #20

Open
jasonmp85 opened this issue Jan 28, 2019 · 0 comments
Open

Address compiler warnings on some packaging platforms #20

jasonmp85 opened this issue Jan 28, 2019 · 0 comments
Labels
Area 📦 Packaging Effort 🎒 Medium effort/Suitable for veterans Need 🔍 Needs investigation Type ♻️ Refactoring or cleanup

Comments

@jasonmp85
Copy link
Contributor

I believe these are from an RPM build; they've been sitting on my desktop for quite a while. At minimum, we should address them in the codebase. Ideally, we'd add the flags to our own builds to ensure we don't regress.

Output from a sort | count run

   3 /7.6.0.citus~git.20181101.3616939/src/backend/distributed/commands/multi_copy.c:1291:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   3 /7.6.0.citus~git.20181101.3616939/src/backend/distributed/utils/citus_clauses.c:77:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   1 /7.6.0.citus~git.20181101.3616939/src/backend/distributed/utils/ruleutils_10.c:4487:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
   1 /7.6.0.citus~git.20181101.3616939/src/backend/distributed/utils/ruleutils_11.c:4489:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
   3 /usr/include/postgresql/10/server/utils/elog.h:108:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   3 /usr/include/postgresql/11/server/utils/elog.h:108:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   3 /usr/include/postgresql/9.6/server/utils/elog.h:108:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   1 W: postgresql-9.6-citus-dbgsym: package-has-long-file-name 72 (81) > 80
  24 configure: WARNING: unrecognized options: --disable-dependency-tracking
   5 dpkg-buildpackage: warning: using a gain-root-command while being root
  12 planner/query_colocation_checker.c:63: warning: 'colocatedJoinChecker.anchorAttributeEquivalences' may be used uninitialized in this function
  12 planner/query_colocation_checker.c:63: warning: 'colocatedJoinChecker.subquery' may be used uninitialized in this function
  12 planner/query_colocation_checker.c:63: warning: 'colocatedJoinChecker.subqueryPlannerRestriction' may be used uninitialized in this function
@jasonmp85 jasonmp85 added Type ♻️ Refactoring or cleanup Effort 🎒 Medium effort/Suitable for veterans Need 🔍 Needs investigation Area 📦 Packaging labels Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area 📦 Packaging Effort 🎒 Medium effort/Suitable for veterans Need 🔍 Needs investigation Type ♻️ Refactoring or cleanup
Projects
None yet
Development

No branches or pull requests

1 participant