Release v2.33.4 using ansi_term 0.12

[rneswold]

Since clap 3.0 is still marked as "beta", can a new 2.33 release be made which uses the latest ansi_term (v0.12)? I use clap and tokio in several projects and I try to eliminate duplicate libraries, when possible. The Tokio tracing crate is using the latest version of ansi_term.

If v3.0 is close to being released, then I'll wait and upgrade my projects to use it, instead.

[pksunkara]

We had decided a long while ago that v2 releases will only be security fixes. While I do empathise with your point, I think trying to upgrade ansi_term from 0.11 to 0.12 is going to distract us from getting the v3 done. Especially when there's no CHANGELOG documented.

[rneswold]

I cloned v2, updated Cargo.toml to use v0.12 of ansi_term, and ran the tests. 400+ succeeded, 0 failed, but there were 5 ignored tests:

• test src/app/mod.rs - app::App::gen_completions (line 1346) ... ignored
• test src/app/mod.rs - app::App::gen_completions (line 1370) ... ignored
• test src/app/mod.rs - app::App::gen_completions_to (line 1412) ... ignored
• test src/app/mod.rs - app::App::name (line 271) ... ignored
• test src/lib.rs - (line 187) ... ignored

However, I restored Cargo.toml to v0.11 of ansi_term and the same tests were ignored.