Skip to content

Undeclared behavior for transfer {:close? true} #38

@lukeneil

Description

@lukeneil

The docstring for transfer documents the behavior of of the :close? flag as the following:

close? - whether the sink should be closed once the transfer is done, defaults to true.

However, on further inspection, transfer-fn appears to close both the source and sink streams when :close? is set, leading to potentially undesirable behavior if the caller is not expecting the source stream to close.

I would suggest either updating the docstring or behavior to be consistent with the user's expectations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions