Skip to content

Commit 66487bb

Browse files
committed
* :op :quote should be :literal? true
* map, vector, quote tests
1 parent 2c92f31 commit 66487bb

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/main/clojure/cljs/analyzer.cljc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2571,6 +2571,7 @@
25712571
(throw (error env "Wrong number of args to quote")))
25722572
(let [expr (analyze-const env x)]
25732573
{:op :quote
2574+
:literal? true
25742575
:expr expr
25752576
:env env
25762577
:form form

src/test/clojure/cljs/analyzer/spec_tests.clj

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,10 @@
146146
x))))]
147147
(is (s/valid? ::a/node node))))
148148

149-
;; map
149+
(deftest test-map
150+
(let [node (no-warn (analyze ns-env '{:foo 1 :bar 2}))]
151+
(is (= :map (:op node)))
152+
(is (s/valid? ::a/node node))))
150153

151154
(deftest test-new
152155
(let [node (no-warn (analyze ns-env '(new String)))]
@@ -162,7 +165,10 @@
162165

163166
;; ns*
164167

165-
;; quote
168+
(deftest test-quote
169+
(let [node (analyze ns-env ''(1 2 3))]
170+
(is (= :quote (:op node)))
171+
(is (s/valid? ::a/node node))))
166172

167173
(deftest test-recur
168174
(let [node (no-warn (analyze ns-env '(fn [x] (recur (inc x)))))]
@@ -183,7 +189,10 @@
183189

184190
;; var
185191

186-
;; vector
192+
(deftest test-map
193+
(let [node (no-warn (analyze ns-env '[1 2]))]
194+
(is (= :vector (:op node)))
195+
(is (s/valid? ::a/node node))))
187196

188197
;; with-meta
189198

0 commit comments

Comments
 (0)