You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just want to start the discussion about one code convention in buffy.
In most buffy code, :refer :all used a lot for including functions in other namespace. I suggest to review this code. Since it might give new user a lot confusion. Sometimes it creates potential issue, especially when there is a function has the same name as a function from clojure.core namespace.
read function also exists in clojure.core namespace. If this code is copied to some different place, it is very hard to tell the read function should be FrameType/read, instead of clojure.core/read.
If you think this change is appropriate, I can make the code change and send the pull request.
The text was updated successfully, but these errors were encountered:
Just want to start the discussion about one code convention in buffy.
In most buffy code, :refer :all used a lot for including functions in other namespace. I suggest to review this code. Since it might give new user a lot confusion. Sometimes it creates potential issue, especially when there is a function has the same name as a function from clojure.core namespace.
For example, some test code (from: https://github.com/clojurewerkz/buffy/blob/master/test/clojurewerkz/buffy/dynamic_test.clj#L18):
read function also exists in clojure.core namespace. If this code is copied to some different place, it is very hard to tell the read function should be FrameType/read, instead of clojure.core/read.
If you think this change is appropriate, I can make the code change and send the pull request.
The text was updated successfully, but these errors were encountered: