avoid re-instantiating Response when not required

cloudflare · Nov 2, 2024 · ab0c9a9 · ab0c9a9
1 parent 96c331d
commit ab0c9a9
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/packages/next-on-pages/templates/_worker.js/handleRequest.ts b/packages/next-on-pages/templates/_worker.js/handleRequest.ts
@@ -114,15 +114,17 @@ async function generateResponse(
 		});
 	}
 
-	const newHeaders = headers.normal;
-	applyHeaders(newHeaders, resp.headers);
-	applyHeaders(newHeaders, headers.important);
-
-	resp = new Response(resp.body, {
-		...resp,
-		status: status || resp.status,
-		headers: newHeaders,
-	});
+	if (status !== null || [...headers.normal].length > 0 || [...headers.important].length > 0) {
+		const newHeaders = headers.normal;
+		applyHeaders(newHeaders, resp.headers);
+		applyHeaders(newHeaders, headers.important);
+
+		resp = new Response(resp.body, {
+			...resp,
+			status: status || resp.status,
+			headers: newHeaders,
+		});
+	}
 
 	return resp;
 }