Response.json() should throw with top level value of function symbol undefined

[huseeiin]

function func() { }
let symb = Symbol("test");
let undef = undefined

let r1 = Response.json(symb);    // should throw here
let r2 = Response.json(func);    // should throw here
let r3 = Response.json(undef);   // should throw here

currently these don't throw. read more: oven-sh/bun#21257

[kentonv]

Indeed it looks like Chrome throws here.

It looks like in cases where the underlying call to JSON.stringify() returns undefined, we should throw.

[jasnell]

@npaun ... fyi... one to add to the fetch spec compliance list.

@huseeiin ... will take a look!

[huseeiin]

Indeed it looks like Chrome throws here.

It looks like in cases where the underlying call to JSON.stringify() returns undefined, we should throw.

i think it should be more like:

if (
  typeof val === "function" ||
  typeof val === "symbol" ||
  typeof val === "undefined"
) {
  throw new Error("Value is not JSON-serializable");
}

return new Response(JSON.stringify(val));

[kentonv]

i think it should be more like:

In all three of those cases, JSON.stringify() returns undefined. (Not the string "undefined", but rather the value undefined.) Seems easier to just check for that since we're calling JSON.stringify() under the hood anyway.