Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fromVitest conditional #7260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix fromVitest conditional #7260

wants to merge 2 commits into from
+1 −1

Conversation

xtian
Copy link

@xtian xtian commented Nov 14, 2024 •
edited
Loading

Checking for /node_modules/vitest/ does not work with Yarn's pnpm linker, where the path is something like node_modules/.store/vitest-virtual-ee893ec3ea/

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: e2e does not cover vitest
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@xtian
Fix fromVitest conditional
2c12d5a 
Checking for `/node_modules/vitest/` does not work with Yarn's pnpm linker, where the path is something like `node_modules/.store/vitest-virtual-ee893ec3ea/`
@xtian xtian requested a review from a team as a code owner November 14, 2024 15:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b70f0d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xtian