Use of legacy library commons-httpclient:commons-httpclient:3.1

[peterhaochen47]

This library is very old and needs to be replaced.

Some examples of usage in our code:

In ExternalOAuthAuthenticationFilter.java

import org.apache.commons.httpclient.util.URIUtil;
...
final String origin = URIUtil.getName(String.valueOf(request.getRequestURL()));

And in TokenMvcMockTests.java in the invalidScopeErrorMessageIsNotShowingAllClientScopes and
invalidScopeErrorMessageIsNotShowingAllUserScopes test methods, for the same import.

See further discussion here: #2689 (comment)

Tasks

Beta Give feedback

1. Remove direct usage, see Remove direct usage of commons-httpclient 3.1 #2826
2. Solve Spring Security SAML2 End of Life  #2561

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186918404

The labels on this github issue will be updated when the story is started.

[strehle]

Will remove UAA usages, but the external dependency still requires it, see dep. tree

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187425661

The labels on this github issue will be updated when the story is started.