From d19cedc090e86768489cec2013c1bc50d321ab12 Mon Sep 17 00:00:00 2001 From: Danny Faught Date: Tue, 26 Mar 2024 16:19:49 -0700 Subject: [PATCH] fix: gradle test might give false green - when failFast = true AND retry is on, there is a serious issue: gradle might stop the test run due to the failFast but still concludes with BUILD SUCCESSFUL (if the retry is successful) - impact: this might cause builds with many failing tests to take longer to finish. [#186986697] Co-authored-by: Peter Chen --- build.gradle | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index b2f42e3e345..807cdee31e6 100644 --- a/build.gradle +++ b/build.gradle @@ -86,7 +86,9 @@ subprojects { test { maxParallelForks = 1 - failFast = true + // when failFast = true AND retry is on, there is a serious issue: + // gradle might stop the test run due to the failFast but still concludes with BUILD SUCCESSFUL (if the retry is successful) + failFast = false useJUnitPlatform() jvmArgs += ["-Xmx1024m", "-XX:+StartAttachListener", "-XX:+HeapDumpOnOutOfMemoryError", "-XX:HeapDumpPath=/var/log/uaa-tests.hprof"]