refactor: move last login, from date, and to date into the options object

Author: esguerrat

lib/provisioning/account.js

@@ -121,23 +121,30 @@ function user(user_id, options = {}, callback) {
  * @param [user_ids] {string[]} - A list of up to 100 user IDs. When provided, other parameters are ignored.
  * @param [prefix] {string} - Returns users where the name or email address begins with the specified case-insensitive
  *                            string.
- * @param [sub_account_id[ {string} - Only returns users who have access to the specified account.
- * @param [last_login] {boolean} - Returns users based on their last login within a specified date range. true for users who logged in, false for users who haven't logged in, undefined for all users.
- * @param [from_date] {Date|string} - Last login start date.
- * @param [to_date] {Date|string} - Last login end date.
- * @param [options] {object} - See {@link https://cloudinary.com/documentation/cloudinary_sdks#configuration_parameters|Configuration parameters} in the SDK documentation.
+ * @param [sub_account_id] {string} - Only returns users who have access to the specified account.
+ * @param [options] {object} - Configuration options. Can include:
+ *                              - lastLogin {boolean} - Returns users based on their last login within a specified date range. true for users who logged in, false for users who haven't logged in, undefined for all users.
+ *                              - fromDate {Date|string} - Last login start date.
+ *                              - toDate {Date|string} - Last login end date.
+ *                              See {@link https://cloudinary.com/documentation/cloudinary_sdks#configuration_parameters|Configuration parameters} in the SDK documentation.
  * @param [callback] {function}
  */
-function users(pending, user_ids, prefix, sub_account_id, last_login, from_date, to_date, options = {}, callback) {
+function users(pending, user_ids, prefix, sub_account_id, options = {}, callback) {
+  // Handle optional callback argument
+  if (typeof options === 'function') {
+    callback = options;
+    options = {};
+  }
+
   let uri = ['users'];
   let params = {
     ids: user_ids,
     pending,
     prefix,
     sub_account_id,
-    last_login,
-    from: from_date,
-    to: to_date
+    last_login: options.lastLogin,
+    from: options.fromDate,
+    to: options.toDate
   };
   return call_account_api('GET', uri, pickOnlyExistingValues(params, "ids", "pending", "prefix", "sub_account_id", "last_login", "from", "to"), callback, options);
 }

types/index.d.ts

@@ -1495,7 +1495,7 @@ declare module 'cloudinary' {
 
                 function user(userId: string, options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>;
 
-                function users(pending: boolean, userIds?: string[], prefix?: string, subAccountId?: string, lastLogin?: boolean, fromDate?: Date | string, toDate?: Date | string, options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>;
+                function users(pending: boolean, userIds?: string[], prefix?: string, subAccountId?: string, options?: ProvisioningApiOptions | { lastLogin?: boolean; fromDate?: Date | string; toDate?: Date | string }, callback?: ResponseCallback): Promise<any>;
 
                 function create_user(name: string, email: string, role: string, subAccountIds?: string[], options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>;