Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whiskey doesn't report exceptions thrown in child processes that originate outside of a test. #57

Open
sam-falvo opened this issue Jun 8, 2013 · 1 comment

Comments

@sam-falvo
Copy link
Contributor

These exceptions cause the test runner to time out, without providing a sensible error message.

Note to myself on how to implement (current brain-dump):

To fix, it looks like we need to insert code somewhere in lib/run_test_file.js close to lines 98-102, to catch any exception, stringify it, and send it along the IPC channel back to the test runner proper. Then, inside the test runner, we need to somehow decode this and provide a sensible (and visible) error diagnostic for the user. Such errors should stop the test run cold as well.

@sam-falvo
Copy link
Contributor Author

Solving this problem would also solve the secondary problem of how to discover and catch NaNs in the coverage report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant