Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instructions to README.md Template for Terraform Pinning #143

Open
osterman opened this issue Mar 11, 2019 · 1 comment
Open

Add Instructions to README.md Template for Terraform Pinning #143

osterman opened this issue Mar 11, 2019 · 1 comment
Assignees
@maximmi

Comments

@osterman
Copy link
Member

what

why

  • Users are pinning to master b/c that's what our examples show
  • This is a bad practice that we don't ourselves use or recommend
@sudoforge
Copy link

It would be easy enough to substitute master for tags/{{ tag_version }} in documentation. Users who are copypasting examples should get an error when Terraform attempts to clone the module if they don't change it to a valid value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximmi maximmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@osterman @maximmi @sudoforge