fix: Resolve unsupported attribute error in S3 website block (#358)

* fix: Resolve unsupported attribute error in S3 website block

Resolves #354

* chore: Comment updates

Author: jwadolowski

examples/complete/website.tf

@@ -0,0 +1,34 @@
+module "website_default" {
+  source = "../../"
+
+  namespace = var.namespace
+  stage     = var.stage
+  name      = var.name
+
+  // Distinguish this module instance from the one in main.tf and prevent S3 bucket name collisions
+  attributes = concat(var.attributes, ["website"])
+
+  cloudfront_access_logging_enabled = false
+
+  website_enabled = true
+
+  context = module.this.context
+}
+
+module "website_redirect_all" {
+  source = "../../"
+
+  namespace = var.namespace
+  stage     = var.stage
+  name      = var.name
+
+  // Distinguish this module instance from the one in main.tf and prevent S3 bucket name collisions
+  attributes = concat(var.attributes, ["website-redirect-all"])
+
+  cloudfront_access_logging_enabled = false
+
+  website_enabled          = true
+  redirect_all_requests_to = "https://cloudposse.com"
+
+  context = module.this.context
+}

main.tf

@@ -319,11 +319,12 @@ resource "aws_s3_bucket" "origin" {
 
   dynamic "website" {
     for_each = var.website_enabled ? local.website_config[var.redirect_all_requests_to == "" ? "default" : "redirect_all"] : []
+    # The lookup is needed to safely access optional website config keys, since locals defines 2 distinct flavours of website config
     content {
-      error_document           = website.value.error_document
-      index_document           = website.value.index_document
-      redirect_all_requests_to = website.value.redirect_all_requests_to
-      routing_rules            = website.value.routing_rules
+      error_document           = lookup(website.value, "error_document", null)
+      index_document           = lookup(website.value, "index_document", null)
+      redirect_all_requests_to = lookup(website.value, "redirect_all_requests_to", null)
+      routing_rules            = lookup(website.value, "routing_rules", null)
     }
   }
 }