Skip to content

Commit 58181b9

Browse files
clivezaosterman
authored andcommitted
Output variable was referencing incorrect value (#7)
1 parent ec81678 commit 58181b9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ aws acm request-certificate --domain-name example.com --subject-alternative-name
3333
| `attributes` | `[]` | Additional attributes (e.g. `policy` or `role`) | No |
3434
| `tags` | `{}` | Additional tags (e.g. `map("BusinessUnit","XYZ")` | No |
3535
| `acm_certificate_arn` | `` | Existing ACM Certificate ARN | No |
36-
| `aliases` | `[]` | List of aliases | Yes |
36+
| `aliases` | `[]` | List of aliases as a FQDN (e.g. `["www.example.com"]`) | Yes |
3737
| `allowed_methods` | `["*"]` | List of allowed methods (e.g. ` GET, PUT, POST, DELETE, HEAD`) for AWS CloudFront | No |
3838
| `cached_methods` | `["GET", "HEAD"]` | List of cached methods (e.g. ` GET, PUT, POST, DELETE, HEAD`) | No |
3939
| `comment` | `Managed by Terraform` | Comment for the origin access identity | No |

outputs.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ output "cf_hosted_zone_id" {
2323
}
2424

2525
output "s3_bucket" {
26-
value = "${null_resource.default.bucket}"
26+
value = "${null_resource.default.triggers.bucket}"
2727
}
2828

2929
output "s3_bucket_domain_name" {
30-
value = "${null_resource.default.bucket_domain_name}"
30+
value = "${null_resource.default.triggers.bucket_domain_name}"
3131
}

variables.tf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ variable "acm_certificate_arn" {
2020
}
2121

2222
variable "aliases" {
23-
type = "list"
24-
default = []
23+
type = "list"
24+
description = "List of FQDN's - Used to set the Alternate Domain Names (CNAMEs) setting on Cloudfront"
25+
default = []
2526
}
2627

2728
variable "origin_bucket" {

0 commit comments

Comments
 (0)