fix: ec2 instance constant termination/creation if ebs enabled #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
www44
changed the title
|
/terratest |
|
Please rebuild the docs and push up |
|
/terratest |
nitrocode
previously approved these changes
Sep 9, 2024
|
/terratest |
|
Please let me know what I may do to merge this 🙏 |
|
/terratest |
|
/terratest |
|
@nitrocode fixed |
nitrocode
approved these changes
Nov 23, 2024
|
@goruha thanks. it might be better to exclude the examples dir from the tflint check. I had to do the same fix in another repo so it's possible that more repos may be affected. I also approved but it's still requires codeowner approval from cloudposse/admins. Could you review this PR? |
goruha
approved these changes
Nov 27, 2024
gberenice
approved these changes
Nov 27, 2024
milldr
approved these changes
Nov 27, 2024
|
These changes were released in v0.31.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix AWS instance idempotency if an EBS volume is configured.
why
references