Skip to content

Commit 97b4275

Browse files
committed
fix etcd config
1 parent 36b591d commit 97b4275

File tree

4 files changed

+12
-16
lines changed

4 files changed

+12
-16
lines changed

config/etcd/client/circuit_breaker.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131

3232
// WithCircuitBreaker sets the circuit breaker policy from etcd configuration center.
3333
func WithCircuitBreaker(dest, src string, etcdClient etcd.Client, uniqueID int64, opts utils.Options) []client.Option {
34-
param, err := etcdClient.ClientConfigParam(&common.ConfigParamConfig{
34+
param, err := etcdClient.ClientConfigParam(&etcd.ConfigParamConfig{
3535
Category: circuitBreakerConfigName,
3636
ServerServiceName: dest,
3737
ClientServiceName: src,
@@ -85,12 +85,12 @@ func initCircuitBreaker(key, dest, src string,
8585
cb := circuitbreak.NewCBSuite(genServiceCBKeyWithRPCInfo)
8686
lcb := common.ThreadSafeSet{}
8787

88-
onChangeCallback := func(restoreDefault bool, data string, parser common.ConfigParser) {
88+
onChangeCallback := func(restoreDefault bool, data string, parser etcd.ConfigParser) {
8989
set := common.Set{}
9090
configs := map[string]circuitbreak.CBConfig{}
9191

9292
if !restoreDefault {
93-
err := parser.Decode(common.JSON, data, &configs)
93+
err := parser.Decode(data, &configs)
9494
if err != nil {
9595
klog.Warnf("[etcd] %s client etcd circuit breaker: unmarshal data %s failed: %s, skip...", key, data, err)
9696
return

config/etcd/client/degradation.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ package client
1717
import (
1818
"context"
1919

20-
common "github.com/cloudwego-contrib/cwgo-pkg/config/common"
21-
2220
"github.com/cloudwego-contrib/cwgo-pkg/config/etcd/etcd"
2321
"github.com/cloudwego-contrib/cwgo-pkg/config/etcd/pkg/degradation"
2422
"github.com/cloudwego-contrib/cwgo-pkg/config/etcd/utils"
@@ -28,7 +26,7 @@ import (
2826
)
2927

3028
func WithDegradation(dest, src string, etcdClient etcd.Client, uniqueID int64, opts utils.Options) []client.Option {
31-
param, err := etcdClient.ClientConfigParam(&common.ConfigParamConfig{
29+
param, err := etcdClient.ClientConfigParam(&etcd.ConfigParamConfig{
3230
Category: degradationConfigName,
3331
ServerServiceName: dest,
3432
ClientServiceName: src,
@@ -53,10 +51,10 @@ func WithDegradation(dest, src string, etcdClient etcd.Client, uniqueID int64, o
5351

5452
func initDegradationOptions(key, dest string, uniqueID int64, etcdClient etcd.Client) *degradation.Container {
5553
container := degradation.NewContainer()
56-
onChangeCallback := func(restoreDefault bool, data string, parser common.ConfigParser) {
54+
onChangeCallback := func(restoreDefault bool, data string, parser etcd.ConfigParser) {
5755
config := &degradation.Config{}
5856
if !restoreDefault {
59-
err := parser.Decode(common.JSON, data, config)
57+
err := parser.Decode(data, config)
6058
if err != nil {
6159
klog.Warnf("[etcd] %s server etcd degradation config: unmarshal data %s failed: %s, skip...", key, data, err)
6260
return

config/etcd/client/retry.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import (
2828

2929
// WithRetryPolicy sets the retry policy from etcd configuration center.
3030
func WithRetryPolicy(dest, src string, etcdClient etcd.Client, uniqueID int64, opts utils.Options) []client.Option {
31-
param, err := etcdClient.ClientConfigParam(&common.ConfigParamConfig{
31+
param, err := etcdClient.ClientConfigParam(&etcd.ConfigParamConfig{
3232
Category: retryConfigName,
3333
ServerServiceName: dest,
3434
ClientServiceName: src,
@@ -60,12 +60,12 @@ func initRetryContainer(key, dest string,
6060

6161
ts := common.ThreadSafeSet{}
6262

63-
onChangeCallback := func(restoreDefault bool, data string, parser common.ConfigParser) {
63+
onChangeCallback := func(restoreDefault bool, data string, parser etcd.ConfigParser) {
6464
// the key is method name, wildcard "*" can match anything.
6565
rcs := map[string]*retry.Policy{}
6666

6767
if !restoreDefault {
68-
err := parser.Decode(common.JSON, data, &rcs)
68+
err := parser.Decode(data, &rcs)
6969
if err != nil {
7070
klog.Warnf("[etcd] %s client etcd retry: unmarshal data %s failed: %s, skip...", key, data, err)
7171
return

config/etcd/client/rpc_timeout.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ package client
1717
import (
1818
"context"
1919

20-
common "github.com/cloudwego-contrib/cwgo-pkg/config/common"
21-
2220
"github.com/cloudwego-contrib/cwgo-pkg/config/etcd/etcd"
2321
"github.com/cloudwego-contrib/cwgo-pkg/config/etcd/utils"
2422
"github.com/cloudwego/kitex/client"
@@ -29,7 +27,7 @@ import (
2927

3028
// WithRPCTimeout sets the RPC timeout policy from etcd configuration center.
3129
func WithRPCTimeout(dest, src string, etcdClient etcd.Client, uniqueID int64, opts utils.Options) []client.Option {
32-
param, err := etcdClient.ClientConfigParam(&common.ConfigParamConfig{
30+
param, err := etcdClient.ClientConfigParam(&etcd.ConfigParamConfig{
3331
Category: rpcTimeoutConfigName,
3432
ServerServiceName: dest,
3533
ClientServiceName: src,
@@ -57,10 +55,10 @@ func initRPCTimeoutContainer(key, dest string,
5755
) rpcinfo.TimeoutProvider {
5856
rpcTimeoutContainer := rpctimeout.NewContainer()
5957

60-
onChangeCallback := func(restoreDefault bool, data string, parser common.ConfigParser) {
58+
onChangeCallback := func(restoreDefault bool, data string, parser etcd.ConfigParser) {
6159
configs := map[string]*rpctimeout.RPCTimeout{}
6260
if !restoreDefault {
63-
err := parser.Decode(common.JSON, data, &configs)
61+
err := parser.Decode(data, &configs)
6462
if err != nil {
6563
klog.Warnf("[etcd] %s client etcd rpc timeout: unmarshal data %s failed: %s, skip...", key, data, err)
6664
return

0 commit comments

Comments
 (0)