fix: panic error contains servicename (#43)

cloudwego · Dec 5, 2023 · dfefcbf · dfefcbf
1 parent 4b32979
commit dfefcbf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pbrpc/failedcall/error_handler/errhandler_test.go b/pbrpc/failedcall/error_handler/errhandler_test.go
@@ -197,7 +197,7 @@ func TestHandlerPanic(t *testing.T) {
 	de := err.(*kerrors.DetailedError)
 	// wrap error is kerrors.ErrRemoteOrNetwork
 	test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
-	test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
+	test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
 	// internal is *remote.TransError
 	te := de.Unwrap().(*remote.TransError)
 	test.Assert(t, te.TypeID() == remote.InternalError)
@@ -212,7 +212,7 @@ func TestHandlerPanic(t *testing.T) {
 	de = err.(*kerrors.DetailedError)
 	// wrap error is kerrors.ErrRemoteOrNetwork
 	test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
-	test.Assert(t, strings.Contains(err.Error(), "remote or network error: rpc error: code = 13 desc = panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
+	test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
 	// internal is *status.Error
 	se, ok := status.FromError(err)
 	test.Assert(t, ok)

diff --git a/thriftrpc/failedcall/error_handler/errhandler_test.go b/thriftrpc/failedcall/error_handler/errhandler_test.go
@@ -122,7 +122,7 @@ func TestHandlerPanic(t *testing.T) {
 	de := err.(*kerrors.DetailedError)
 	// wrap error is kerrors.ErrRemoteOrNetwork
 	test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
-	test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
+	test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
 	// internal is *remote.TransError
 	te := de.Unwrap().(*remote.TransError)
 	test.Assert(t, te.TypeID() == remote.InternalError)

diff --git a/thriftrpc/failedmux/error_handler/errhandler_test.go b/thriftrpc/failedmux/error_handler/errhandler_test.go
@@ -99,7 +99,7 @@ func TestHandlerPanic(t *testing.T) {
 	de := err.(*kerrors.DetailedError)
 	// wrap error is kerrors.ErrRemoteOrNetwork
 	test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
-	test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
+	test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
 	// internal is *remote.TransError
 	te := de.Unwrap().(*remote.TransError)
 	test.Assert(t, te.TypeID() == remote.InternalError)