Skip to content

Commit dfefcbf

Browse files
authored
fix: panic error contains servicename (#43)
1 parent 4b32979 commit dfefcbf

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pbrpc/failedcall/error_handler/errhandler_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func TestHandlerPanic(t *testing.T) {
197197
de := err.(*kerrors.DetailedError)
198198
// wrap error is kerrors.ErrRemoteOrNetwork
199199
test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
200-
test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
200+
test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
201201
// internal is *remote.TransError
202202
te := de.Unwrap().(*remote.TransError)
203203
test.Assert(t, te.TypeID() == remote.InternalError)
@@ -212,7 +212,7 @@ func TestHandlerPanic(t *testing.T) {
212212
de = err.(*kerrors.DetailedError)
213213
// wrap error is kerrors.ErrRemoteOrNetwork
214214
test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
215-
test.Assert(t, strings.Contains(err.Error(), "remote or network error: rpc error: code = 13 desc = panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
215+
test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
216216
// internal is *status.Error
217217
se, ok := status.FromError(err)
218218
test.Assert(t, ok)

thriftrpc/failedcall/error_handler/errhandler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ func TestHandlerPanic(t *testing.T) {
122122
de := err.(*kerrors.DetailedError)
123123
// wrap error is kerrors.ErrRemoteOrNetwork
124124
test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
125-
test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
125+
test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
126126
// internal is *remote.TransError
127127
te := de.Unwrap().(*remote.TransError)
128128
test.Assert(t, te.TypeID() == remote.InternalError)

thriftrpc/failedmux/error_handler/errhandler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func TestHandlerPanic(t *testing.T) {
9999
de := err.(*kerrors.DetailedError)
100100
// wrap error is kerrors.ErrRemoteOrNetwork
101101
test.Assert(t, de.ErrorType() == kerrors.ErrRemoteOrNetwork)
102-
test.Assert(t, strings.Contains(err.Error(), "remote or network error[remote]: panic: [happened in biz handler, method=testSTReq] mock handler panic"), err.Error())
102+
test.Assert(t, strings.Contains(err.Error(), "happened in biz handler"), err.Error())
103103
// internal is *remote.TransError
104104
te := de.Unwrap().(*remote.TransError)
105105
test.Assert(t, te.TypeID() == remote.InternalError)

0 commit comments

Comments
 (0)