chore: fix CI problem

Author: DMwangnima

pkg/remote/trans/ttstream/cancel_stream_task_test.go

@@ -55,6 +55,7 @@ func TestCancelStreamTaskConfig(t *testing.T) {
 	ticker = nil
 }
 
+// todo: optimized unit time-consuming
 func TestCancelStreamTask(t *testing.T) {
 	cfd, sfd := netpoll.GetSysFdPairs()
 	cconn, err := netpoll.NewFDConnection(cfd)
@@ -88,7 +89,7 @@ func TestCancelStreamTask(t *testing.T) {
 			req := new(testRequest)
 			req.A = 123
 			if sErr := cs.SendMsg(cCtx, req); sErr != nil {
-				//test.Assert(t, sErr == defaultCancelStreamTaskConfig.CancelException, sErr)
+				// test.Assert(t, sErr == defaultCancelStreamTaskConfig.CancelException, sErr)
 				wg.Done()
 				break
 			}
@@ -97,7 +98,7 @@ func TestCancelStreamTask(t *testing.T) {
 
 	for {
 		if rErr := ss.RecvMsg(sCtx, new(testResponse)); rErr != nil {
-			//test.Assert(t, errors.Is(rErr, newExceptionType(context.Canceled.Error(), nil, 12008)), rErr)
+			// test.Assert(t, errors.Is(rErr, newExceptionType(context.Canceled.Error(), nil, 12008)), rErr)
 			wg.Done()
 			break
 		}
@@ -112,7 +113,7 @@ func TestCancelStreamTask(t *testing.T) {
 	test.Assert(t, err == nil, err)
 
 	cs = newClientStream(rawClientStream)
-	ss = newServerStream(rawClientStream)
+	ss = newServerStream(rawServerStream)
 
 	wg.Add(2)
 	go func() {
@@ -144,7 +145,7 @@ func TestCancelStreamTask(t *testing.T) {
 	test.Assert(t, err == nil, err)
 
 	cs = newClientStream(rawClientStream)
-	ss = newServerStream(rawClientStream)
+	ss = newServerStream(rawServerStream)
 
 	wg.Add(2)
 	go func() {

pkg/remote/trans/ttstream/client_provider.go

@@ -90,7 +90,7 @@ func (c clientProvider) NewStream(ctx context.Context, ri rpcinfo.RPCInfo) (stre
 	if strHeader == nil {
 		strHeader = map[string]string{}
 	}
-	// retrieve deadline fron context as the whole stream timeout
+	// retrieve deadline from context as the whole stream timeout
 	if ddl, ok := ctx.Deadline(); ok {
 		tm := time.Until(ddl)
 		intHeader[ttheader.RPCTimeout] = strconv.Itoa(int(tm.Milliseconds()))

pkg/remote/trans/ttstream/transport.go

@@ -47,10 +47,8 @@ func isIgnoreError(err error) bool {
 	return errors.Is(err, netpoll.ErrEOF) || errors.Is(err, io.EOF) || errors.Is(err, netpoll.ErrConnClosed)
 }
 
-var (
-	// ticker is used to manage closeStreamTask.
-	ticker *utils.SharedTicker
-)
+// ticker is used to manage closeStreamTask.
+var ticker *utils.SharedTicker
 
 // transport is used to read/write frames and disturbed frames to different streams
 type transport struct {
@@ -207,6 +205,7 @@ func (t *transport) readFrame(reader bufiox.Reader) error {
 		var ok bool
 		s, ok = t.loadStream(fr.sid)
 		if !ok {
+			// todo: think about remove this error log since this is a very common
 			klog.Errorf("transport[%d] read a unknown stream: frame[%s]", t.kind, fr.String())
 			// ignore unknown stream error
 			err = nil