remove references to MS365 CLI for auth

Author: hongooi73

NEWS.md

@@ -10,6 +10,11 @@
 
 - Fix a bug in the `ms_plan$get_details()` method.
 
+## Other
+
+- Remove references to the Microsoft365 CLI, as this no longer has a multi-tenant app registration and hence cannot be used for authentication. This means you'll have to either allow the Microsoft365R app ID within your tenant or create your own app registration (both of which will require Azure admin access). (#215)
+
+
 # Microsoft365R 2.4.0
 
 ## OneDrive/SharePoint

R/Microsoft365R.R

@@ -98,8 +98,9 @@ utils::globalVariables(c("self", "private"))
 # default app ID
 .microsoft365r_app_id <- "d44a05d5-c6a5-4bbb-82d2-443123722380"
 
+## no longer supported as of Sep 2024
 # CLI for Microsoft 365 app ID
-.cli_microsoft365_app_id <- "31359c7f-bd7e-475c-86db-fdb8c937548e"
+## .cli_microsoft365_app_id <- "31359c7f-bd7e-475c-86db-fdb8c937548e"
 
 # helper functions
 error_message <- get("error_message", getNamespace("AzureGraph"))

R/client.R

@@ -276,11 +276,7 @@ do_login <- function(tenant, app, scopes, token, ...)
 choose_app <- function(app)
 {
     if(is.null(app) || app == "")
-    {
-        if(!is.null(getOption("microsoft365r_use_cli_app_id")))
-            .cli_microsoft365_app_id
-        else .microsoft365r_app_id
-    }
+        .microsoft365r_app_id
     else app
 }
 

vignettes/auth.Rmd

@@ -71,22 +71,13 @@ See the vignettes "Using Microsoft365R in a Shiny app" and "Using Microsoft365R
 
 ### Using other app registrations: last-resort workarounds
 
-The above methods are the **recommended solutions** to dealing with access restrictions on Microsoft365R. If they are not feasible, it's possible to work around these issues by piggybacking on other apps:
-
-- By setting the R option `microsoft365r_use_cli_app_id` to a non-NULL value, Microsoft365R will authenticate using the app ID for the CLI for Microsoft 365---effectively pretending to be the CLI itself. Technically this app still requires admin approval, but it is in widespread use and is maintained by Microsoft employees, and so may already be allowed in your organisation. The CLI supports most Microsoft 365 services, but not Outlook or personal OneDrive.
-
-  ```r
-  options(microsoft365r_use_cli_app_id=TRUE)
-  get_team("My team")
-  ```
-
-- You can authenticate using the Azure CLI's app ID: `04b07795-8ddb-461a-bbee-02f9e1bf7b46`. This is a first-party Microsoft app, and hence can be used in any tenant. It is not intended for use with Microsoft 365, so not all functionality may be supported; however it should be possible to access Teams and SharePoint sites (but not Outlook, personal OneDrive or OneDrive for Business).
+The above methods are the **recommended solutions** to dealing with access restrictions on Microsoft365R. If they are not feasible, it's possible to work around these issues by using the Azure CLI's app ID: `04b07795-8ddb-461a-bbee-02f9e1bf7b46`. This is a first-party Microsoft app, and hence can be used in any tenant. It is not intended for use with Microsoft 365, so not all functionality may be supported; however it should be possible to access Teams and SharePoint sites (but not Outlook, personal OneDrive or OneDrive for Business).
 
   ```r
   get_sharepoint_site("My site", app="04b07795-8ddb-461a-bbee-02f9e1bf7b46")
   ```
 
-Be warned that these workarounds may draw the attention of your admin!
+Be warned that this may draw the attention of your admin!
 
 
 ## Authenticating with a token