Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of [unknown discussion] placeholder by completely hiding unknown discussions of DiscussionReferencedPost #37

Open
n-peugnet opened this issue Feb 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@n-peugnet
Copy link
Member

As @rob006 explained:

To be clear, I think that it would be much better to completely hide info about references in DiscussionReferencedPost, if they're not accessible. So if DiscussionReferencedPost has info about 2 discussions, but one of them is unavailable, then display info only about one available discussion. If all discussions in DiscussionReferencedPost are unavailable, then I would hide this event post completely. In this way we can avoid unnecessary noise and unintentional revealing of some information (currently you don't know title of discussion, but you still can see that specific person mentioned this discussion).

So if you decide to not have a setting to enable replacing unavailable discussion with placeholder, there will be no scenario with placeholder at all.

After thinking a little bit about it, I think I like this approach. But to implement it properly kind of requires #13 if we filter them in the frontend.
Another problem is that I don't know how to completely invalidate an EventPost in the frontend. Maybe I could override the view() method, but it would probably not look good. Maybe the best way would be to filter them from the backend, but not sure how feasible it would be.

Originally posted by @n-peugnet in #35 (comment)

@n-peugnet n-peugnet changed the title Completely get rid of [unknown discussion] placeholder Get rid of [unknown discussion] placeholder by completely hiding unknown discussions of DiscussionReferencedPost Feb 19, 2023
@n-peugnet n-peugnet added the enhancement New feature or request label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant