Dead: Fixed crash for selfbot when trying to move corpse from below the surface when on a different map

mostlikely4r · mostlikely4r · commit 557f80020094 · 2025-01-20T19:35:08.000+01:00
diff --git a/playerbot/strategy/actions/ReviveFromCorpseAction.cpp b/playerbot/strategy/actions/ReviveFromCorpseAction.cpp
@@ -79,7 +79,7 @@ bool FindCorpseAction::Execute(Event& event)
     float corpseDist = botPos.distance(corpsePos);
 
     //If player fell through terrain move corpse to player position.
-    if (bot->isRealPlayer())
+    if (bot->isRealPlayer() && botPos.getMapId() == moveToPos.getMapId())
     {
         //Try to correct the position upward.
         if (!moveToPos.ClosestCorrectPoint(5.0f, 500.0f, bot->GetInstanceId()))

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ bool FindCorpseAction::Execute(Event& event)`
`79`	`79`	`float corpseDist = botPos.distance(corpsePos);`
`80`	`80`
`81`	`81`	`//If player fell through terrain move corpse to player position.`
`82`		`- if (bot->isRealPlayer())`
	`82`	`+ if (bot->isRealPlayer() && botPos.getMapId() == moveToPos.getMapId())`
`83`	`83`	`{`
`84`	`84`	`//Try to correct the position upward.`
`85`	`85`	`if (!moveToPos.ClosestCorrectPoint(5.0f, 500.0f, bot->GetInstanceId()))`