Equip: Remove irrelevant leftover check. (#232)

ileboii · web-flow · commit 9cc081c80de5 · 2025-12-09T20:00:31.000+03:00
diff --git a/playerbot/strategy/values/ItemUsageValue.cpp b/playerbot/strategy/values/ItemUsageValue.cpp
@@ -578,7 +578,6 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemQualifier& itemQualifier, P
     }
 
     bool shouldEquip = false;
-    bool isAllowedForSpec = true;
 
     uint32 specId = sRandomItemMgr.GetPlayerSpecId(bot);
 
@@ -681,7 +680,7 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemQualifier& itemQualifier, P
     Item* item = CurrentItem(itemProto, bot);
     bool itemIsBroken = item && item->GetUInt32Value(ITEM_FIELD_DURABILITY) == 0 && item->GetUInt32Value(ITEM_FIELD_MAXDURABILITY) > 0;
     bool oldItemIsBroken = oldItem->GetUInt32Value(ITEM_FIELD_DURABILITY) == 0 && oldItem->GetUInt32Value(ITEM_FIELD_MAXDURABILITY) > 0;
-    if (isAllowedForSpec && itemProto->ItemId != oldItemProto->ItemId && (shouldEquip || !existingShouldEquip) && isBetter)
+    if (itemProto->ItemId != oldItemProto->ItemId && (shouldEquip || !existingShouldEquip) && isBetter)
     {
         switch (itemProto->Class)
         {

Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,6 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemQualifier& itemQualifier, P`
`578`	`578`	`}`
`579`	`579`
`580`	`580`	`bool shouldEquip = false;`
`581`		`- bool isAllowedForSpec = true;`
`582`	`581`
`583`	`582`	`uint32 specId = sRandomItemMgr.GetPlayerSpecId(bot);`
`584`	`583`
`@@ -681,7 +680,7 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemQualifier& itemQualifier, P`
`681`	`680`	`Item* item = CurrentItem(itemProto, bot);`
`682`	`681`	`bool itemIsBroken = item && item->GetUInt32Value(ITEM_FIELD_DURABILITY) == 0 && item->GetUInt32Value(ITEM_FIELD_MAXDURABILITY) > 0;`
`683`	`682`	`bool oldItemIsBroken = oldItem->GetUInt32Value(ITEM_FIELD_DURABILITY) == 0 && oldItem->GetUInt32Value(ITEM_FIELD_MAXDURABILITY) > 0;`
`684`		`- if (isAllowedForSpec && itemProto->ItemId != oldItemProto->ItemId && (shouldEquip \|\| !existingShouldEquip) && isBetter)`
	`683`	`+ if (itemProto->ItemId != oldItemProto->ItemId && (shouldEquip \|\| !existingShouldEquip) && isBetter)`
`685`	`684`	`{`
`686`	`685`	`switch (itemProto->Class)`
`687`	`686`	`{`