wix4

Author: cmbant

.github/workflows/build_gui_apps.yml

@@ -163,6 +163,10 @@ jobs:
           }
 
           echo "WiX v4 installed successfully"
+
+          # Note: We don't need to install WiX extensions for our basic MSI installer
+          # If needed in the future, uncomment the line below
+          # dotnet tool install --global WixToolset.Util.wixext
         }
 
         # Display WiX version (should not fail the build if this fails)

scripts/create_windows_msi.py

@@ -180,18 +180,15 @@ def create_wix_files(input_dir, version):
 <Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
     <Fragment>
         <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
-            <!-- In WiX 4, Files element must be a direct child of Fragment, Directory, DirectoryRef, etc. -->
-            <!-- Not a child of Component -->
-            <Component Id="MainExecutable" Guid="*" KeyPath="yes">
+            <Component Id="MainExecutable" Guid="*">
                 <File Id="GetDistGUIEXE" Source="{input_dir_forward}/GetDistGUI.exe" KeyPath="yes" />
             </Component>
-        </ComponentGroup>
 
-        <!-- Use Files element at Fragment level for all other files -->
-        <Files Directory="INSTALLFOLDER" Source="{input_dir_forward}/*">
-            <!-- Exclude the main executable which is already included above -->
-            <Exclude Name="GetDistGUI.exe" />
-        </Files>
+            <!-- Add a component for each file in the directory -->
+            <Component Id="AppFiles" Guid="*">
+                <File Source="{input_dir_forward}/*" Exclude="GetDistGUI.exe" />
+            </Component>
+        </ComponentGroup>
     </Fragment>
 </Wix>
 """
@@ -229,7 +226,7 @@ def build_msi(wxs_path, components_wxs_path, output_dir, version):
         build_cmd = [
             "wix", "build",
             "-v", # Verbose output
-            "-ext", "WixToolset.Util.wixext", # Add Util extension for better error handling
+            # Extension removed as it's not installed in the workflow environment
             "-o", msi_path,
             wxs_path,
             components_wxs_path