Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to support async requests? #30

Closed
dshemetov opened this issue Jun 3, 2024 · 4 comments
Closed

Do we need to support async requests? #30

dshemetov opened this issue Jun 3, 2024 · 4 comments

Comments

@dshemetov
Copy link
Contributor

We have async request functionality here. Not having worked with async much, I have questions:

  • what is the main use case?
  • can we do without it?

My guess at the first is: it helps when making many requests in parallel. My guess at the second is: yes, we don't have that functionality in epidatr and that client works well enough.

Removing async support would reduce maintenance work and would allow us to switch completely to delphi-epidata.py as the backend (see #29).

There is an async smoke test here and a regular one here. Those could provide some good examples to get started in testing.

@dshemetov
Copy link
Contributor Author

Found some discussion from a while ago.

@dshemetov
Copy link
Contributor Author

Also this issue.

@dshemetov
Copy link
Contributor Author

TL;DR of above issues:

  • async calls were originally intended to get around row limits and pagination in the old PHP server
  • current row limits are much larger and we don't do pagination, thus this feature is no longer necessary
  • async it will be deprecated in covidcast client and eventually downstream code will stop using it
  • we can therefore remove this functionality here and simplify the code, this work will happen here refactor+clean: simplify package internals and clean configs #28

@dshemetov
Copy link
Contributor Author

Closed by #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant