Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider caching old common location set to check if we should rerender the truth plot, instead of using an observer #272

Open
nmdefries opened this issue Apr 25, 2023 · 0 comments

Comments

@nmdefries
Copy link
Collaborator

To save plot rendering/computation time in #271, we could also save the previous locationsIntersect to a user session-specific global and check during the next call to summaryPlot() if it has changed. If locationsIntersect has changed, make a new truth plot.

Potential problems:

  • Because it is in an observer, the re-plotting logic in
    locationsIntersect <- filteredScoreDfAndIntersections[[2]]
    is confined to cases where the forecaster selection has changed. If we move the logic to summaryPlot() truth re-plotting could be triggered in other cases that we don't need/want.
  • It's unclear how much extra time making a new truth plot takes. The re-plotting logic re-renders the old plot and rendering is slow.
@nmdefries nmdefries changed the title Cache old common location set to check if we should rerender the truth plot, instead of using an observer Consider caching old common location set to check if we should rerender the truth plot, instead of using an observer Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant