You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To save plot rendering/computation time in #271, we could also save the previous locationsIntersect to a user session-specific global and check during the next call to summaryPlot() if it has changed. If locationsIntersect has changed, make a new truth plot.
Potential problems:
Because it is in an observer, the re-plotting logic in
is confined to cases where the forecaster selection has changed. If we move the logic to summaryPlot() truth re-plotting could be triggered in other cases that we don't need/want.
It's unclear how much extra time making a new truth plot takes. The re-plotting logic re-renders the old plot and rendering is slow.
The text was updated successfully, but these errors were encountered:
nmdefries
changed the title
Cache old common location set to check if we should rerender the truth plot, instead of using an observer
Consider caching old common location set to check if we should rerender the truth plot, instead of using an observer
Apr 25, 2023
To save plot rendering/computation time in #271, we could also save the previous
locationsIntersect
to a user session-specific global and check during the next call tosummaryPlot()
if it has changed. IflocationsIntersect
has changed, make a new truth plot.Potential problems:
observer
, the re-plotting logic inforecast-eval/app/server.R
Line 239 in 49896af
summaryPlot()
truth re-plotting could be triggered in other cases that we don't need/want.The text was updated successfully, but these errors were encountered: