|
| 1 | +package main |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "testing" |
| 6 | + |
| 7 | + "github.com/google/go-github/v55/github" |
| 8 | +) |
| 9 | + |
| 10 | +// Additional comprehensive tests for all rule types |
| 11 | + |
| 12 | +func TestLabeler_ProcessMatchRule_RemoveCommand(t *testing.T) { |
| 13 | + client := NewMockGitHubClient() |
| 14 | + config := createTestConfigWithRemoveRules() |
| 15 | + labeler := NewLabeler(client, config) |
| 16 | + |
| 17 | + // Add some existing labels |
| 18 | + triageLabel := &github.Label{Name: stringPtr("triage/valid")} |
| 19 | + tagLabel := &github.Label{Name: stringPtr("tag/infrastructure")} |
| 20 | + client.IssueLabels[1] = []*github.Label{triageLabel, tagLabel} |
| 21 | + |
| 22 | + req := &LabelRequest{ |
| 23 | + Owner: "test-owner", |
| 24 | + Repo: "test-repo", |
| 25 | + IssueNumber: 1, |
| 26 | + CommentBody: "/remove-triage valid", |
| 27 | + ChangedFiles: []string{}, |
| 28 | + } |
| 29 | + |
| 30 | + ctx := context.Background() |
| 31 | + err := labeler.ProcessRequest(ctx, req) |
| 32 | + if err != nil { |
| 33 | + t.Fatalf("ProcessRequest failed: %v", err) |
| 34 | + } |
| 35 | + |
| 36 | + // Check that triage/valid was removed |
| 37 | + removedLabels := client.RemovedLabels[1] |
| 38 | + if !sliceContains(removedLabels, "triage/valid") { |
| 39 | + t.Errorf("Expected 'triage/valid' to be removed, got: %v", removedLabels) |
| 40 | + } |
| 41 | +} |
| 42 | + |
| 43 | +func TestLabeler_ProcessFilePathRule_MultipleFiles(t *testing.T) { |
| 44 | + client := NewMockGitHubClient() |
| 45 | + config := createTestConfigWithFilePathRules() |
| 46 | + labeler := NewLabeler(client, config) |
| 47 | + |
| 48 | + req := &LabelRequest{ |
| 49 | + Owner: "test-owner", |
| 50 | + Repo: "test-repo", |
| 51 | + IssueNumber: 1, |
| 52 | + CommentBody: "", |
| 53 | + ChangedFiles: []string{ |
| 54 | + "tags/tag-infrastructure/charter.md", |
| 55 | + "tags/tag-developer-experience/README.md", |
| 56 | + }, |
| 57 | + } |
| 58 | + |
| 59 | + ctx := context.Background() |
| 60 | + err := labeler.ProcessRequest(ctx, req) |
| 61 | + if err != nil { |
| 62 | + t.Fatalf("ProcessRequest failed: %v", err) |
| 63 | + } |
| 64 | + |
| 65 | + // Check that toc label was applied (for charter.md) |
| 66 | + appliedLabels := client.AppliedLabels[1] |
| 67 | + if !sliceContains(appliedLabels, "toc") { |
| 68 | + t.Errorf("Expected 'toc' label to be applied, got: %v", appliedLabels) |
| 69 | + } |
| 70 | + if !sliceContains(appliedLabels, "tag/developer-experience") { |
| 71 | + t.Errorf("Expected 'tag/developer-experience' label to be applied, got: %v", appliedLabels) |
| 72 | + } |
| 73 | +} |
| 74 | + |
| 75 | +func TestLabeler_ProcessMatchRule_WildcardRemoval(t *testing.T) { |
| 76 | + client := NewMockGitHubClient() |
| 77 | + config := createTestConfigWithWildcardRules() |
| 78 | + labeler := NewLabeler(client, config) |
| 79 | + |
| 80 | + // Add multiple triage labels |
| 81 | + triageValid := &github.Label{Name: stringPtr("triage/valid")} |
| 82 | + triageDuplicate := &github.Label{Name: stringPtr("triage/duplicate")} |
| 83 | + client.IssueLabels[1] = []*github.Label{triageValid, triageDuplicate} |
| 84 | + |
| 85 | + req := &LabelRequest{ |
| 86 | + Owner: "test-owner", |
| 87 | + Repo: "test-repo", |
| 88 | + IssueNumber: 1, |
| 89 | + CommentBody: "/clear-triage", |
| 90 | + ChangedFiles: []string{}, |
| 91 | + } |
| 92 | + |
| 93 | + ctx := context.Background() |
| 94 | + err := labeler.ProcessRequest(ctx, req) |
| 95 | + if err != nil { |
| 96 | + t.Fatalf("ProcessRequest failed: %v", err) |
| 97 | + } |
| 98 | + |
| 99 | + // Check that all triage/* labels were removed |
| 100 | + removedLabels := client.RemovedLabels[1] |
| 101 | + if !sliceContains(removedLabels, "triage/valid") { |
| 102 | + t.Errorf("Expected 'triage/valid' to be removed, got: %v", removedLabels) |
| 103 | + } |
| 104 | + if !sliceContains(removedLabels, "triage/duplicate") { |
| 105 | + t.Errorf("Expected 'triage/duplicate' to be removed, got: %v", removedLabels) |
| 106 | + } |
| 107 | +} |
| 108 | + |
| 109 | +func TestLabeler_ProcessComplexScenario(t *testing.T) { |
| 110 | + client := NewMockGitHubClient() |
| 111 | + config := createTestConfig() |
| 112 | + labeler := NewLabeler(client, config) |
| 113 | + |
| 114 | + // Start with needs-triage label |
| 115 | + needsTriageLabel := &github.Label{Name: stringPtr("needs-triage")} |
| 116 | + client.IssueLabels[1] = []*github.Label{needsTriageLabel} |
| 117 | + |
| 118 | + req := &LabelRequest{ |
| 119 | + Owner: "test-owner", |
| 120 | + Repo: "test-repo", |
| 121 | + IssueNumber: 1, |
| 122 | + CommentBody: `This is a complex scenario. |
| 123 | +/triage valid |
| 124 | +/tag developer-experience |
| 125 | +Some more comments here.`, |
| 126 | + ChangedFiles: []string{"tags/tag-developer-experience/some-file.md"}, |
| 127 | + } |
| 128 | + |
| 129 | + ctx := context.Background() |
| 130 | + err := labeler.ProcessRequest(ctx, req) |
| 131 | + if err != nil { |
| 132 | + t.Fatalf("ProcessRequest failed: %v", err) |
| 133 | + } |
| 134 | + |
| 135 | + appliedLabels := client.AppliedLabels[1] |
| 136 | + removedLabels := client.RemovedLabels[1] |
| 137 | + |
| 138 | + // Should remove needs-triage |
| 139 | + if !sliceContains(removedLabels, "needs-triage") { |
| 140 | + t.Errorf("Expected 'needs-triage' to be removed, got: %v", removedLabels) |
| 141 | + } |
| 142 | + |
| 143 | + // Should apply triage/valid and tag/developer-experience |
| 144 | + if !sliceContains(appliedLabels, "triage/valid") { |
| 145 | + t.Errorf("Expected 'triage/valid' to be applied, got: %v", appliedLabels) |
| 146 | + } |
| 147 | + if !sliceContains(appliedLabels, "tag/developer-experience") { |
| 148 | + t.Errorf("Expected 'tag/developer-experience' to be applied, got: %v", appliedLabels) |
| 149 | + } |
| 150 | +} |
| 151 | + |
| 152 | +// Helper functions for additional test configs |
| 153 | + |
| 154 | +func createTestConfigWithRemoveRules() *LabelsYAML { |
| 155 | + config := createTestConfig() |
| 156 | + config.Ruleset = append(config.Ruleset, Rule{ |
| 157 | + Name: "remove-triage", |
| 158 | + Kind: "match", |
| 159 | + Spec: RuleSpec{ |
| 160 | + Command: "/remove-triage", |
| 161 | + }, |
| 162 | + Actions: []Action{ |
| 163 | + { |
| 164 | + Kind: "remove-label", |
| 165 | + Spec: ActionSpec{Match: "triage/{{ argv.0 }}"}, |
| 166 | + }, |
| 167 | + }, |
| 168 | + }) |
| 169 | + return config |
| 170 | +} |
| 171 | + |
| 172 | +func createTestConfigWithFilePathRules() *LabelsYAML { |
| 173 | + config := createTestConfig() |
| 174 | + config.Ruleset = append(config.Ruleset, Rule{ |
| 175 | + Name: "tag-developer-experience-dir", |
| 176 | + Kind: "filePath", |
| 177 | + Spec: RuleSpec{ |
| 178 | + MatchPath: "tags/tag-developer-experience/*", |
| 179 | + }, |
| 180 | + Actions: []Action{ |
| 181 | + { |
| 182 | + Kind: "apply-label", |
| 183 | + Spec: ActionSpec{Label: "tag/developer-experience"}, |
| 184 | + }, |
| 185 | + }, |
| 186 | + }) |
| 187 | + return config |
| 188 | +} |
| 189 | + |
| 190 | +func createTestConfigWithWildcardRules() *LabelsYAML { |
| 191 | + config := createTestConfig() |
| 192 | + config.Ruleset = append(config.Ruleset, Rule{ |
| 193 | + Name: "clear-triage", |
| 194 | + Kind: "match", |
| 195 | + Spec: RuleSpec{ |
| 196 | + Command: "/clear-triage", |
| 197 | + }, |
| 198 | + Actions: []Action{ |
| 199 | + { |
| 200 | + Kind: "remove-label", |
| 201 | + Spec: ActionSpec{Match: "triage/*"}, |
| 202 | + }, |
| 203 | + }, |
| 204 | + }) |
| 205 | + return config |
| 206 | +} |
0 commit comments