Turn on various flags in hermes-parser that we plan to make on-by-default soon

Reviewed By: marcoww6

Differential Revision: D82697071

fbshipit-source-id: a581654a14468163de02df347a941a46d4f1c3fd

Author: SamChou19815

tools/hermes-parser/js/.flowconfig

@@ -27,6 +27,16 @@ component_syntax=true
 enums=true
 experimental.pattern_matching=true
 
+experimental.constant_condition=true
+experimental.constant_condition.null_void.includes=<PROJECT_ROOT>
+experimental.constant_condition.boolean_literal.includes=<PROJECT_ROOT>
+experimental.constant_condition.function.includes=<PROJECT_ROOT>
+experimental.constant_condition.invalid_comparison.general.includes=<PROJECT_ROOT>
+experimental.constant_condition.invalid_comparison.null_check.includes=<PROJECT_ROOT>
+
+experimental.natural_inference.array_object_literals.implicit_instantiation_fix=true
+experimental.natural_inference.jsx_literal=true
+
 [version]
 ^0.283.0
 

tools/hermes-parser/js/hermes-eslint/src/scope-manager/scope/ScopeBase.js

@@ -246,17 +246,24 @@ type VariableScope =
     this.type = type;
 
     this.__dynamic =
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.Global || this.type === ScopeType.With;
 
     this.block = block;
 
     this.variableScope =
       this.type === ScopeType.ClassFieldInitializer ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.ClassStaticBlock ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.Function ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.Global ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.Module ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.DeclareModule ||
+      // $FlowFixMe[invalid-compare]
       this.type === ScopeType.DeclareNamespace
         ? // $FlowFixMe[incompatible-type] not possible to teach flow this is safe
           this

tools/hermes-parser/js/hermes-estree/src/predicates.js

@@ -135,6 +135,7 @@ export function isExpression(node /*: ESNode */) /*: implies node is Expression
     node.type === 'ArrayExpression' ||
     node.type === 'ObjectExpression' ||
     // $FlowFixMe[incompatible-type]
+    // $FlowFixMe[invalid-compare]
     node.type === 'ObjectExpression' ||
     node.type === 'FunctionExpression' ||
     node.type === 'ArrowFunctionExpression' ||

tools/hermes-parser/js/hermes-parser/src/babel/TransformESTreeToBabel.js

@@ -753,6 +753,7 @@ function mapTypeofTypeAnnotation(
   // $FlowExpectedError[cannot-write]
   delete node.typeArguments;
   // $FlowFixMe[incompatible-type]
+  // $FlowFixMe[invalid-compare]
   if (node.argument.type !== 'GenericTypeAnnotation') {
     return nodeWith(node, {
       // $FlowExpectedError[incompatible-type] Special override for Babel
@@ -920,6 +921,7 @@ function transformNode(node: ESNodeOrBabelNode): ESNodeOrBabelNode | null {
     case 'Program': {
       // Check if we have already processed this node.
       // $FlowFixMe[incompatible-type]
+      // $FlowFixMe[invalid-compare]
       if (node.parent?.type === 'File') {
         return node;
       }
@@ -1263,6 +1265,7 @@ export function transformProgram(
   });
 
   // $FlowFixMe[incompatible-type]
+  // $FlowFixMe[invalid-compare]
   if (resultNode?.type === 'File') {
     return resultNode;
   }

tools/hermes-parser/js/hermes-parser/src/transform/astNodeMutationHelpers.js

@@ -48,6 +48,7 @@ function getParentKey(
         parent[key],
       )
     ) {
+      // $FlowFixMe[invalid-compare]
       if (parent[key] === target) {
         return {type: 'single', node: parent, key};
       }

tools/hermes-parser/js/hermes-transform/src/transform/mutations/ModifyNodeInPlace.js

@@ -40,6 +40,7 @@ export function performModifyNodeInPlaceMutation(
     const prevPropValue = target[key];
 
     // If the value did not change, skip.
+    // $FlowFixMe[invalid-compare]
     if (prevPropValue === newPropValue) {
       continue;
     }

tools/hermes-parser/js/hermes-transform/src/transform/mutations/RemoveNode.js

@@ -216,6 +216,7 @@ function getRemovalParent(node: RemoveNodeMutation['node']): $ReadOnly<{
             return 'properties';
 
           // $FlowFixMe[incompatible-type]
+          // $FlowFixMe[invalid-compare]
           case 'OptionalCallExpression':
           case 'CallExpression':
           case 'NewExpression':
@@ -247,6 +248,7 @@ function getRemovalParent(node: RemoveNodeMutation['node']): $ReadOnly<{
             return 'properties';
 
           // $FlowFixMe[incompatible-type]
+          // $FlowFixMe[invalid-compare]
           case 'OptionalCallExpression':
           case 'CallExpression':
           case 'NewExpression':
@@ -275,6 +277,7 @@ function getRemovalParent(node: RemoveNodeMutation['node']): $ReadOnly<{
     // $FlowExpectedError[prop-missing]
     const arr = node.parent[key];
     const idx = arr.indexOf(node);
+    // $FlowFixMe[invalid-compare]
     if (idx === -1) {
       throw new InvalidRemovalError(
         `Could not find target in array of \`${node.parent.type}.${key}\`.`,

tools/hermes-parser/js/hermes-transform/src/transform/mutations/ReplaceNode.js

@@ -90,6 +90,7 @@ function getParentKey(target: ESNode): $ReadOnly<
   for (const key of getVisitorKeys(parent)) {
     const child = (parent: $FlowFixMe)[key];
     if (isNode(child)) {
+      // $FlowFixMe[invalid-compare]
       if (child === target) {
         return {type: 'single', parent, key};
       }

tools/hermes-parser/js/hermes-transform/src/transform/mutations/utils/getStatementParent.js

@@ -45,6 +45,7 @@ export function getStatementParent(
       const value = parentWithType[key];
 
       if (
+        // $FlowFixMe[invalid-compare]
         value === target ||
         (Array.isArray(value) && value.includes(target))
       ) {
@@ -136,6 +137,7 @@ export function getStatementParent(
     // array insertions are already validated by the getAssertedIndex function
     result.targetIndex == null &&
     // $FlowExpectedError[prop-missing]
+    // $FlowFixMe[invalid-compare]
     result.parent[result.key] !== target
   ) {
     throw new InvalidStatementError(