Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'Save' and show loading indicator while Survey Designer elements are loading #160

Open
sebastianclarke opened this issue Jul 7, 2015 · 8 comments

Comments

@sebastianclarke
Copy link

When you click 'Design Survey' on an existing survey, depending on system load, it can take some time for the existing fields and elements of the survey to load in and show available for editing. Until this time the survey shows as 'Unsynchronised' but this appears exactly the same as when editing a new survey for the first time, and there is no indication to the user that a load is in progress. If 'Save' is pressed during this period, the current state of the survey is overwritten with a blank one.

Therefore I think that there should be a loading indicator during this process and editing of the fields and saving should be disabled until the existing survey is correctly loaded in to stop users losing their work

@xmichael xmichael added this to the Co-design July launch milestone Jul 7, 2015
panterz pushed a commit to cobweb-eu/fieldtrip-authoring-tool that referenced this issue Jul 10, 2015
panterz pushed a commit to cobweb-eu/fieldtrip-authoring-tool that referenced this issue Jul 10, 2015
@panterz
Copy link

panterz commented Jul 10, 2015

I did a couple of changes:

  1. the application is checking on the user's space if the survey already exists instead of the public space so it's reducing the time of the loaded survey.
  2. I disabled the button while step 1 takes place
  3. added loading button.

@sebastianclarke
Copy link
Author

Is this on live? I am looking at the page
https://dyfi.cobwebproject.eu/geonetwork/private/eng/catalog.search#/metadata/34126aec-5b47-4d10-90c1-2e498e61f110
when logged in as admin, loading the survey designer, and still just seeing
an empty form

On 10 July 2015 at 12:02, Panos Terzis [email protected] wrote:

I did a couple of changes:

  1. the application is checking on the user's space if the survey already
    exists instead of the public space so it's reducing the time of the loaded
    survey.
  2. I disabled the button while step 1 takes place
  3. added loading button.


Reply to this email directly or view it on GitHub
#160 (comment).

Sebastian ClarkeSoftware DeveloperEnvironment Systems
Tel: +44 (0) 1970 626688
www.envsys.co.uk

The information contained in this e-mail is intended only for the use of
the person(s) to whom it is addressed and may contain confidential or
privileged information. If you have received this e-mail in error please
contact the sender and delete the material without copying, distributing or
disclosing the content. All reasonable precautions have been taken to
ensure that this e-mail is free from any virus, however, the recipient
should verify this to be the case. Please 'think before you print'

@panterz
Copy link

panterz commented Jul 10, 2015

Are you the creator of the survey?

@sebastianclarke
Copy link
Author

no, I thought admin user might have rights to modify anyway, I'll ask the
creator to check...

On 10 July 2015 at 12:15, Panos Terzis [email protected] wrote:

Are you the creator of the survey?


Reply to this email directly or view it on GitHub
#160 (comment).

Sebastian ClarkeSoftware DeveloperEnvironment Systems
Tel: +44 (0) 1970 626688
www.envsys.co.uk

The information contained in this e-mail is intended only for the use of
the person(s) to whom it is addressed and may contain confidential or
privileged information. If you have received this e-mail in error please
contact the sender and delete the material without copying, distributing or
disclosing the content. All reasonable precautions have been taken to
ensure that this e-mail is free from any virus, however, the recipient
should verify this to be the case. Please 'think before you print'

@panterz
Copy link

panterz commented Jul 10, 2015

This is what I changed. I am not checking on the 233... (public folder) but on the actual user's space now.

@sebastianclarke
Copy link
Author

would that not mean that any modifications would also happen in the user's
space, and therefore not be reflected on the public survey available for
syncing - or does the 'save' operation save in both?

On 10 July 2015 at 12:18, Panos Terzis [email protected] wrote:

This is what I changed. I am not checking on the 233... (public folder)
but on the actual user's space now.


Reply to this email directly or view it on GitHub
#160 (comment).

Sebastian ClarkeSoftware DeveloperEnvironment Systems
Tel: +44 (0) 1970 626688
www.envsys.co.uk

The information contained in this e-mail is intended only for the use of
the person(s) to whom it is addressed and may contain confidential or
privileged information. If you have received this e-mail in error please
contact the sender and delete the material without copying, distributing or
disclosing the content. All reasonable precautions have been taken to
ensure that this e-mail is free from any virus, however, the recipient
should verify this to be the case. Please 'think before you print'

@panterz
Copy link

panterz commented Jul 10, 2015

Nope, every time you save there's a parameter (public=true/false) that is transferred to the pcapi that does the actual save. If public=true then the pcapi copies the survey to the public folder.

@sebastianclarke
Copy link
Author

great, thanks for the clarification

On 10 July 2015 at 12:22, Panos Terzis [email protected] wrote:

Nope, every time you save there's a parameter (public=true/false) that is
transferred to the pcapi that does the actual save. If public=true then the
pcapi copies the survey to the public folder.


Reply to this email directly or view it on GitHub
#160 (comment).

Sebastian ClarkeSoftware DeveloperEnvironment Systems
Tel: +44 (0) 1970 626688
www.envsys.co.uk

The information contained in this e-mail is intended only for the use of
the person(s) to whom it is addressed and may contain confidential or
privileged information. If you have received this e-mail in error please
contact the sender and delete the material without copying, distributing or
disclosing the content. All reasonable precautions have been taken to
ensure that this e-mail is free from any virus, however, the recipient
should verify this to be the case. Please 'think before you print'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants