Survey Designer loads surveys from public folder

[xmichael]

The survey designer loads surveys from the public folder with public=true. This causes deletion or unpredictable corruption of surveys that were initially private and later became public.

Solution - - remove all GETs that use the public UUID and use private (0000-....) instead

[sebastianclarke]

Possible duplicate of #162

[panterz]

I just deployed it on dev. Does anyone want to test it?

[sebastianclarke]

We're having some problems testing: Mark is getting certificate errors trying to connect the app to the dev environment, we are investigating this further now.

Testing from my machine:
I can confirm that having made a survey as public, and then switching it to private, the survey appears, as created, in the survey designer!
I can confirm, this also works for the reverse, create and modify as private, then switch to public, and the survey opens fine in the designer.
HOWEVER, having joined the private survey, it is not visible in the app under registered surveys after syncing. It is still available as a public survey (known 'ghost' issue) but I cannot confirm this working till I see it successfully load on the app.

The survey id that is failing is ec2ec373-66b2-432b-99e0-00c5082a59ca the uuid of the user is 459f6ea6-0c30-2653-e056-51788fcf0698 - as a matter of interest the wget url shows that the user is a member of the survey... wget -qO- --user=admin --password=admin --auth-no-challenge "http://localhost:8010/geonetwork/private/eng/qi?type=survey&to=100&fast=index&_content_type=json&_participant=459f6ea6-0c30-2653-e056-51788fcf0698"

I was hoping we had solved all the issues with survey membership, but it appears perhaps not.

[panterz]

I've noticed a bug with the portal. If the user changes a survey from private--> public and then tries to edit the survey then the flag of the survey url has public=false instead of public=true which means that any change you do will be applied to the registered survey. The reason that happens is because a new tab opens when the user decides to modify the survey and the initial page is not reloaded after the modification. Is that clear @pvgenuchten @Delawen ?

[panterz]

I deployed it on live. I do confirm the bug I reported above and the fact that changing from public to private the form exists on public surveys.