Skip to content

Commit 70fea30

Browse files
committed
lib: packagemanager: close dbus client
Close the DBus client after checking if packagekit/dnf5daemon dbus's services exist.
1 parent dfd463e commit 70fea30

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

pkg/lib/packagemanager.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,26 +41,32 @@ async function is_immutable_os() {
4141
}
4242

4343
async function detect_dnf5daemon() {
44+
const client = cockpit.dbus("org.rpm.dnf.v0", { superuser: "try" });
45+
let detected = false;
4446
try {
45-
const client = cockpit.dbus("org.rpm.dnf.v0", { superuser: "try" });
4647
await client.call("/org/rpm/dnf/v0", "org.freedesktop.DBus.Peer", "Ping", []);
47-
return true;
48+
detected = true;
4849
} catch (err) {
4950
debug("dnf5daemon not supported", err);
50-
return false;
5151
}
52+
53+
client.close();
54+
return detected;
5255
}
5356

5457
async function detect_packagekit() {
58+
const client = cockpit.dbus("org.freedesktop.PackageKit", { superuser: "try" });
59+
let detected = false;
5560
try {
56-
const client = cockpit.dbus("org.freedesktop.PackageKit", { superuser: "try" });
5761
await client.call("/org/freedesktop/PackageKit", "org.freedesktop.DBus.Properties",
5862
"Get", ["org.freedesktop.PackageKit", "VersionMajor"]);
59-
return true;
63+
detected = true;
6064
} catch (err) {
6165
debug("PackageKit not supported", err);
62-
return false;
6366
}
67+
68+
client.close();
69+
return detected;
6470
}
6571

6672
// Cache result for a session

0 commit comments

Comments
 (0)