Skip to content

sstable: EstimateDiskUsage doesn't work on vtables with synthetic prefix #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RaduBerinde opened this issue Apr 22, 2025 · 1 comment
Open

sstable: EstimateDiskUsage doesn't work on vtables with synthetic prefix #4597

RaduBerinde opened this issue Apr 22, 2025 · 1 comment
Labels
A-storage C-bug Something isn't working O-support T-storage

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Apr 22, 2025 •
edited by cockroach-jira-scripts
Loading

EstimateDiskUsage uses the keys with the physical table, without setting up the proper iter transforms.

Note that this function is used by estimateReclaimedSizeBeneath which is used to calculate RangeDeletionsBytesEstimate (which is important for compaction heuristics).

Jira issue: PEBBLE-419
@RaduBerinde RaduBerinde added the C-bug Something isn't working label Apr 22, 2025
@RaduBerinde
Copy link
Member Author

This was discovered while auditing code for an escalation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-storage C-bug Something isn't working O-support T-storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RaduBerinde