Skip to content

manifest: explicitly encode excise operations in the MANIFEST #4798

Open
@jbowens

Description

@jbowens

The replay package is used for compaction benchmarking. It captures data from flushes and ingestions to create a stable compaction workload. It then replays it on a Pebble instance, allowing for focused benchmarking of compactions and their heuristics. However, this process was not updated with the addition of excise, and excises are not repeated. This results in a deviation between the replay database and the original workload.

Trying to deduce the exicse bounds from existing version edit data is a bit fraught and likely fragile. We could instead explicitly encode the excise operation within the version edit, mapping a span to the sequence number at which the excise was performed. This would also allow us to strengthen invariant checking on manifest replay, and then would also allow the replay package to replay excises.

Jira issue: PEBBLE-463

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions