Document unsafe blocks in memory management code #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
msft-jlange
reviewed
Jul 1, 2025
joergroedel
force-pushed
the
document-unsafe-blocks
branch
from
4663ac0 to
7563c01
Compare
msft-jlange
reviewed
Jul 7, 2025
msft-jlange
reviewed
Jul 7, 2025
msft-jlange
reviewed
Jul 7, 2025
msft-jlange
reviewed
Jul 7, 2025
joergroedel
force-pushed
the
document-unsafe-blocks
branch
from
7563c01 to
7fc198d
Compare
Add SAFETY annotation to all unsafe blocks in the memory allocator implementation. Signed-off-by: Joerg Roedel <[email protected]>
Document GuestPtr and friends' unsafe blocks. Signed-off-by: Joerg Roedel <[email protected]>
This removes the need to explicitly specify Send + Sync on the Mapping and VMM data structures. Also the explicit Send + Sync annotations where VirtualMapping is used are redundant. Signed-off-by: Joerg Roedel <[email protected]>
Document the safety of the unsafe block in the PageBox implementation. Signed-off-by: Joerg Roedel <[email protected]>
Document the unsafe blocks in the page-table code which have not documentation yet. Signed-off-by: Joerg Roedel <[email protected]>
Document any undocumented unsafe blocks in the page-visibility code. One usage is actually not safe and needs to be fixed in a follow-on PR. Signed-off-by: Joerg Roedel <[email protected]>
Document any undocumented unsafe blocks in the page-table guards code. Signed-off-by: Joerg Roedel <[email protected]>
Document any undocumented unsafe blocks in kernel/src/mm/validate.rs. Signed-off-by: Joerg Roedel <[email protected]>
joergroedel
force-pushed
the
document-unsafe-blocks
branch
from
7fc198d to
195ef0e
Compare
msft-jlange
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents all not-yet documented unsafe blocks in the memory management code.